[GitHub] [incubator-weex] darkThanBlack edited a comment on issue #2656: [iOS] The PR #2394 does not included in latest release version

[GitBox <gi...@apache.org>]

darkThanBlack edited a comment on issue #2656: [iOS] The PR #2394 does not included in latest release version
URL: https://github.com/apache/incubator-weex/issues/2656#issuecomment-508755568
 
 
   Let's take a look:
   
   ```
   + (WXBridgeManager *)bridgeMgr
   {
       WXBridgeManager* result = [self sharedInstance].bridgeMgr;
       if (result == nil) {
           // devtool may invoke "unload" and set bridgeMgr to nil
           result = [[WXBridgeManager alloc] init];
           [self sharedInstance].bridgeMgr = result;
       }
       return result;
   }
   ```
   
   Recreate instance in singleton is uncommon code, particularly he also add a comment ``devtool may invoke "unload" and set bridgeMgr to nil``. There must be some reason here.
   I have found ``weex playground`` source code in iOS have some serious problems when user change ``JS Debug Mode`` switch in ``weex dev-tool`` html, ``weex SDK`` will not refresh itself correctly, but I have not completely traced the reason. These codes may related to it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services