You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2019/06/03 17:23:52 UTC

[kudu-CR] docs: update docs for heap sampling

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13459 )

Change subject: docs: update docs for heap sampling
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13459/1/docs/troubleshooting.adoc
File docs/troubleshooting.adoc:

http://gerrit.cloudera.org:8080/#/c/13459/1/docs/troubleshooting.adoc@a640
PS1, Line 640: 
> Should we add a doc on how to disable heap sampling?
I don't think so, unless we hear of some case where it caused problems for someone. Otherwise people might start thinking it's a thing that "needs tuning for production" and I don't want people to make false optimizations



-- 
To view, visit http://gerrit.cloudera.org:8080/13459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bdf8b2175f1bc492e98dc2a815bde4ab8fbe626
Gerrit-Change-Number: 13459
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 03 Jun 2019 17:23:52 +0000
Gerrit-HasComments: Yes