You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by jatin9896 <gi...@git.apache.org> on 2017/12/07 05:21:07 UTC
[GitHub] carbondata pull request #1629: [CARBONDATA-1714] Fixed Issue for Selection o...
GitHub user jatin9896 opened a pull request:
https://github.com/apache/carbondata/pull/1629
[CARBONDATA-1714] Fixed Issue for Selection of null values after having multiple alter commands
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed? No
- [ ] Any backward compatibility impacted? No
- [ ] Document update required? No
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required? No
- How it is tested? Please attach test report. NA
- Is it a performance related change? Please attach the performance test report. NA
- Any additional information to help reviewers in testing this change. NA
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jatin9896/incubator-carbondata CARBONDATA-1714
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1629.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1629
----
commit 78a30778c4171cede160e091fabce2c95a556dbf
Author: Jatin <ja...@knoldus.in>
Date: 2017-12-07T05:11:37Z
fixed Issue for selection of null values after having muliple alter commands
----
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by jatin9896 <gi...@git.apache.org>.
Github user jatin9896 commented on the issue:
https://github.com/apache/carbondata/pull/1629
retest this please
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1629
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1973/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by jatin9896 <gi...@git.apache.org>.
Github user jatin9896 commented on the issue:
https://github.com/apache/carbondata/pull/1629
retest this please
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1629
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1844/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1629
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/790/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by jatin9896 <gi...@git.apache.org>.
Github user jatin9896 commented on the issue:
https://github.com/apache/carbondata/pull/1629
retest this please
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by jatin9896 <gi...@git.apache.org>.
Github user jatin9896 commented on the issue:
https://github.com/apache/carbondata/pull/1629
retest this please
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1629
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2024/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1629
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2446/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1629
Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/745/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1629
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2179/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1629
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2309/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1629
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1995/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1629
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2031/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1629
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/798/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1629
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1991/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1629
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/543/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1629
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2293/
---
[GitHub] carbondata pull request #1629: [CARBONDATA-1714] Fixed Issue for Selection o...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1629#discussion_r157761421
--- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java ---
@@ -804,7 +804,7 @@ public QueryModel getQueryModel(InputSplit inputSplit, TaskAttemptContext taskAt
Expression filter = getFilterPredicates(configuration);
boolean[] isFilterDimensions = new boolean[carbonTable.getDimensionOrdinalMax()];
boolean[] isFilterMeasures =
- new boolean[carbonTable.getNumberOfMeasures(carbonTable.getTableName())];
--- End diff --
Please add comment in the code :)
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1629
Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/747/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by jatin9896 <gi...@git.apache.org>.
Github user jatin9896 commented on the issue:
https://github.com/apache/carbondata/pull/1629
retest this please
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/1629
LGTM
---
[GitHub] carbondata pull request #1629: [CARBONDATA-1714] Fixed Issue for Selection o...
Posted by jatin9896 <gi...@git.apache.org>.
Github user jatin9896 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1629#discussion_r157790360
--- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java ---
@@ -804,7 +804,7 @@ public QueryModel getQueryModel(InputSplit inputSplit, TaskAttemptContext taskAt
Expression filter = getFilterPredicates(configuration);
boolean[] isFilterDimensions = new boolean[carbonTable.getDimensionOrdinalMax()];
boolean[] isFilterMeasures =
- new boolean[carbonTable.getNumberOfMeasures(carbonTable.getTableName())];
--- End diff --
done please review.
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1629
Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/760/
---
[GitHub] carbondata pull request #1629: [CARBONDATA-1714] Fixed Issue for Selection o...
Posted by jatin9896 <gi...@git.apache.org>.
Github user jatin9896 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1629#discussion_r157711859
--- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java ---
@@ -804,7 +804,7 @@ public QueryModel getQueryModel(InputSplit inputSplit, TaskAttemptContext taskAt
Expression filter = getFilterPredicates(configuration);
boolean[] isFilterDimensions = new boolean[carbonTable.getDimensionOrdinalMax()];
boolean[] isFilterMeasures =
- new boolean[carbonTable.getNumberOfMeasures(carbonTable.getTableName())];
--- End diff --
getNumberOfMeasures doesn't include column count which was dropped but it exists in measure list with invisible true whereas the getAllmeasures also include the recent dropped column as well.
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1629
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2150/
---
[GitHub] carbondata pull request #1629: [CARBONDATA-1714] Fixed Issue for Selection o...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1629#discussion_r157701509
--- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java ---
@@ -804,7 +804,7 @@ public QueryModel getQueryModel(InputSplit inputSplit, TaskAttemptContext taskAt
Expression filter = getFilterPredicates(configuration);
boolean[] isFilterDimensions = new boolean[carbonTable.getDimensionOrdinalMax()];
boolean[] isFilterMeasures =
- new boolean[carbonTable.getNumberOfMeasures(carbonTable.getTableName())];
--- End diff --
Can u please add comment why you are calling getAllMeasures() instead of getNumberOfMeasures(carbonTable.getTableName())
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1629
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1800/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by jatin9896 <gi...@git.apache.org>.
Github user jatin9896 commented on the issue:
https://github.com/apache/carbondata/pull/1629
retest this please
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/1629
@jatin9896 Can u please add a testcase for this scenario
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by jatin9896 <gi...@git.apache.org>.
Github user jatin9896 commented on the issue:
https://github.com/apache/carbondata/pull/1629
retest this please
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1629
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2176/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1629
Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/919/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1629
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2432/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1629
Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/765/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by jatin9896 <gi...@git.apache.org>.
Github user jatin9896 commented on the issue:
https://github.com/apache/carbondata/pull/1629
retest this please
---
[GitHub] carbondata pull request #1629: [CARBONDATA-1714] Fixed Issue for Selection o...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1629
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1629
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/950/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1629
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2177/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1629
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2335/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1629
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1977/
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by jatin9896 <gi...@git.apache.org>.
Github user jatin9896 commented on the issue:
https://github.com/apache/carbondata/pull/1629
@kumarvishal09 Please verify.
---
[GitHub] carbondata issue #1629: [CARBONDATA-1714] Fixed Issue for Selection of null ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1629
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/616/
---