You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/24 12:18:39 UTC
[GitHub] [arrow-rs] tustvold opened a new issue #1482: Use Arrow take kernel Within ListArrayReader
tustvold opened a new issue #1482:
URL: https://github.com/apache/arrow-rs/issues/1482
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
The `ListArrayReader` currently uses a custom `remove_indices` function in order to strip nulls from its values array.
**Describe the solution you'd like**
This function is very similar to the arrow take kernel, and with some minor tweaks we can likely eliminate a non-trivial amount of code from the parquet crate, whilst also potentially improving performance
**Describe alternatives you've considered**
The code could remain unchanged
**Additional context**
Originally pointed out [here](https://github.com/apache/arrow-rs/pull/1448#discussion_r831080215)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold edited a comment on issue #1482: Use Arrow take kernel Within ListArrayReader
Posted by GitBox <gi...@apache.org>.
tustvold edited a comment on issue #1482:
URL: https://github.com/apache/arrow-rs/issues/1482#issuecomment-1079741765
I have no imminent plans to do this, so it would be great if you could 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on issue #1482: Use Arrow take kernel Within ListArrayReader
Posted by GitBox <gi...@apache.org>.
tustvold commented on issue #1482:
URL: https://github.com/apache/arrow-rs/issues/1482#issuecomment-1079741765
That would be great if you could 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on issue #1482: Use Arrow take kernel Within ListArrayReader
Posted by GitBox <gi...@apache.org>.
viirya commented on issue #1482:
URL: https://github.com/apache/arrow-rs/issues/1482#issuecomment-1079741455
@tustvold Do you plan to do this? If not, I might take some time in the weekend to play with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb closed issue #1482: Use Arrow take kernel Within ListArrayReader
Posted by GitBox <gi...@apache.org>.
alamb closed issue #1482:
URL: https://github.com/apache/arrow-rs/issues/1482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org