[GitHub] [daffodil-vscode] arosien commented on a diff in pull request #625: Add conditional defaults to TDML properties

["arosien (via GitHub)" <gi...@apache.org>]

arosien commented on code in PR #625:
URL: https://github.com/apache/daffodil-vscode/pull/625#discussion_r1188136291


##########
src/utils.ts:
##########
@@ -120,12 +130,16 @@ export function getConfig(
     tdmlConfig: tdmlConfig
       ? tdmlConfig
       : {
-          action: defaultConf.get('tdmlAction', 'none'),
-          name: defaultConf.get('tdmlName', '${command:AskforTDMLName}'),
-          description: defaultConf.get(
-            'tdmlDescription',
-            '${command:AskForTDMLDescription}'
-          ),
+          action: tdmlAction,
+          name: tdmlPropsNeeded
+            ? defaultConf.get('tdmlName', '${command:AskforTDMLName}')
+            : defaultConf.get('tdmlName', 'tdmlNamePlaceholder}'),

Review Comment:
   I don't think there should be an action of type `none`; if you don't want a TDML action then the TDML config section should be optional. Then there won't be any need to suppress variable interpolations, and if you do want an action then the variables will get interpolated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org