[GitHub] [flink] 1u0 opened a new pull request #8602: [FLINK-12313] Add workaround to avoid race condition in SynchronousCheckpointITCase test

[GitBox <gi...@apache.org>]

1u0 opened a new pull request #8602: [FLINK-12313] Add workaround to avoid race condition in SynchronousCheckpointITCase test
URL: https://github.com/apache/flink/pull/8602
 
 
   ## What is the purpose of the change
   
   The `SynchronousCheckpointITCase` has a race condition and with some chance may fail on random tests on CI. This PR adds an additional synchronization point as a workaround to avoid the issue.
   
   Additionally, the PR simplifies (refactors) the test, although the race condition is present in both refactored and non-refactored versions.
   
   ## Brief change log
   
     - The test is simplified to not use dedicated locks for general flow checks. The test run set to limited by a timeout.
     - Added a hacky synchronization point in `advanceToEndOfEventTime` method, to make sure that `triggerCheckpoint` thread has progressed far enough, before triggering `notifyCheckpointComplete`.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services