You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/03/29 16:47:18 UTC

[GitHub] [daffodil-vscode] Shanedell opened a new pull request #98: DFDL Intellisense

Shanedell opened a new pull request #98:
URL: https://github.com/apache/daffodil-vscode/pull/98


   This PR wires Regis's DFDL language/intellisense extension.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil-vscode] Shanedell closed pull request #98: DFDL Intellisense

Posted by GitBox <gi...@apache.org>.
Shanedell closed pull request #98:
URL: https://github.com/apache/daffodil-vscode/pull/98


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil-vscode] stevedlawrence commented on pull request #98: DFDL Intellisense

Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on pull request #98:
URL: https://github.com/apache/daffodil-vscode/pull/98#issuecomment-1082146300


   I would prefer that if Regis wrote the code then he also open the pull request, since he was the author and has the rights to grant that code to apache.
   
   Also, we should wait for after 1.0.0 is released before merging any new functionality.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil-vscode] Shanedell commented on pull request #98: DFDL Intellisense

Posted by GitBox <gi...@apache.org>.
Shanedell commented on pull request #98:
URL: https://github.com/apache/daffodil-vscode/pull/98#issuecomment-1082124509


   @rthomas320 Hey Regis can you give this look over and make sure everything is functioning good for you?
   
   Also have you looked into how to get the some color into the files with the `dfdl.xsd` extension? That is the only thing I noticed wasn't there that would be nice to have. Most things are just the default color other than text wrapped in double quotes being different. But it would be nice to have comments be gray, start of tags be green or some other color. A code baseline for colors would probably just be looking at what is used in `xml` files.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil-vscode] Shanedell commented on pull request #98: DFDL Intellisense

Posted by GitBox <gi...@apache.org>.
Shanedell commented on pull request #98:
URL: https://github.com/apache/daffodil-vscode/pull/98#issuecomment-1082169523


   @stevedlawrence Yeah my apologies I put this PR to the wrong fork at first. It was meant to go into the CTC fork.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org