You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/07/03 23:29:02 UTC
[GitHub] rahul003 commented on a change in pull request #11429: Improve
sparse pull performance for gluon trainer
rahul003 commented on a change in pull request #11429: Improve sparse pull performance for gluon trainer
URL: https://github.com/apache/incubator-mxnet/pull/11429#discussion_r199961435
##########
File path: python/mxnet/kvstore.py
##########
@@ -247,8 +247,8 @@ def pull(self, key, out=None, priority=0):
The returned values are guaranteed to be the latest values in the store.
- For `RowSparseNDArray` values, this call is ignored,
- please use ``row_sparse_pull`` instead.
+ pull with `RowSparseNDArray` is not supported for dist kvstore.
+ Please use ``row_sparse_pull`` instead.
Review comment:
Should ignore_sparse be defaulted to false to be consistent with previous behavior?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services