You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by Ethanlm <gi...@git.apache.org> on 2018/05/04 18:12:13 UTC

[GitHub] storm pull request #2657: STORM-3048 : A Potential NPE

Github user Ethanlm commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2657#discussion_r186169251
  
    --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java ---
    @@ -135,6 +136,7 @@ private static boolean checkConstraintsSatisfied(Cluster cluster, TopologyDetail
     
         private static boolean checkSpreadSchedulingValid(Cluster cluster, TopologyDetails topo) {
             LOG.info("Checking for a valid scheduling...");
    +        assert(cluster.getAssignmentById(topo.getId())!=null);
    --- End diff --
    
    nit: same here


---