You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/19 08:44:46 UTC

[GitHub] [cloudstack] davidjumani opened a new pull request #4843: ui: deployvm - Add option to stay on page

davidjumani opened a new pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843


   ### Description
   
   Adds the option to stay on the deploy VM page
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   
   ### How Has This Been Tested?
   
   ![Screenshot from 2021-03-19 14-13-59](https://user-images.githubusercontent.com/8244774/111753882-5fa86500-88bd-11eb-91b6-edda92742f09.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4843: ui: deployvm - Add option to stay on page

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843#issuecomment-871992205


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4843 (SL-JID-306)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4843: ui: deployvm - Add option to stay on page

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843#issuecomment-802719667


   @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4843: ui: deployvm - Add option to stay on page

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843#issuecomment-802720299


   @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4843: ui: deployvm - Add option to stay on page

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843#issuecomment-803746879


   @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4843: ui: deployvm - Add option to stay on page

Posted by GitBox <gi...@apache.org>.

rhtyd commented on pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843#issuecomment-803806428


   -1 we need to discuss what's the best way to address this or if users would need this at all. If users need to deploy multiple VMs we can consider a different UX, or ideally users should use APIs/cmk for automation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4843: ui: deployvm - Add option to stay on page

Posted by GitBox <gi...@apache.org>.

DaanHoogland commented on pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843#issuecomment-803921190


   @rhtyd this is a good case for displaying the APIs being called during the dialog as cmk script!?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] andrijapanicsb merged pull request #4843: ui: deployvm - Add option to stay on page

Posted by GitBox <gi...@apache.org>.

andrijapanicsb merged pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4843: ui: deployvm - Add option to stay on page

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843#issuecomment-866895916


   Hi @davidjumani are you still working on this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4843: ui: deployvm - Add option to stay on page

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843#issuecomment-803766492


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4843 (SL-JID-48)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4843: ui: deployvm - Add option to stay on page

Posted by GitBox <gi...@apache.org>.

DaanHoogland commented on pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843#issuecomment-806036818


   > @DaanHoogland sorry didn't get your comment,, what is cmk to do with the UI change?
   
   It doesn't and it doesn't relate to this change. But this change description by @davidjumani is a good argument for having a cmk CLI description of what you do in the UI. This can be convenient for operators that are learning or setting up new environments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4843: ui: deployvm - Add option to stay on page

Posted by GitBox <gi...@apache.org>.

davidjumani commented on pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843#issuecomment-803809401


   @rhtyd This is intended for when a user might want to deploy multiple VMs with different templates, networks etc. This prevents the page from going back and keeps the form data so the user can change only what he wants 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4843: ui: deployvm - Add option to stay on page

Posted by GitBox <gi...@apache.org>.

davidjumani commented on pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843#issuecomment-868382610


   @nvazquez It's ready but I'll send a mail on the ML to get consensus on  this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4843: ui: deployvm - Add option to stay on page

Posted by GitBox <gi...@apache.org>.

davidjumani commented on pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843#issuecomment-871988691


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4843: ui: deployvm - Add option to stay on page

Posted by GitBox <gi...@apache.org>.

davidjumani commented on pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843#issuecomment-802718557


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4843: ui: deployvm - Add option to stay on page

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843#issuecomment-802751673


   Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_check_mark: debian. SL-JID 180


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4843: ui: deployvm - Add option to stay on page

Posted by GitBox <gi...@apache.org>.

rhtyd commented on pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843#issuecomment-873149621


   This creates a slight confusion, I would normally want the drop down to select first and then click the button (examples in other forms such as send email in Gmail or outlook where you toggle/select between send now or later and then click the button later to send the email).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4843: ui: deployvm - Add option to stay on page

Posted by GitBox <gi...@apache.org>.

davidjumani commented on pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843#issuecomment-803746563


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4843: ui: deployvm - Add option to stay on page

Posted by GitBox <gi...@apache.org>.

rhtyd commented on pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843#issuecomment-805551712


   @DaanHoogland sorry didn't get your comment,, what is cmk to do with the UI change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #4843: ui: deployvm - Add option to stay on page

Posted by GitBox <gi...@apache.org>.

shwstppr commented on pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843#issuecomment-868391928


   @davidjumani just a though, will it better to tweak UI something like following to make the option bit more subtle?
   ![Screenshot from 2021-06-25 15-38-16](https://user-images.githubusercontent.com/153340/123409301-a77d0d80-d5cb-11eb-859a-3d5dbb9ebeaf.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4843: ui: deployvm - Add option to stay on page

Posted by GitBox <gi...@apache.org>.

rhtyd commented on pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843#issuecomment-810038150


   @davidjumani while I disagree with the change, I don't want to block if everyone agrees with the feature. Pl start a discussion on dev and users ML.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4843: ui: deployvm - Add option to stay on page

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843#issuecomment-802753730


   Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_check_mark: debian. SL-JID 183


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4843: ui: deployvm - Add option to stay on page

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843#issuecomment-871989469


   @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org