You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2020/03/12 11:02:08 UTC

[kudu-CR] KUDU-3072 Add glog patch to support stacktrace for aarch64 

huangtianhua223@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15420


Change subject: KUDU-3072 Add glog patch to support stacktrace for aarch64
......................................................................

KUDU-3072 Add glog patch to support stacktrace for aarch64

Change-Id: Ia8ca769b2bef5fa658d56d11b7ac9537fd9ca637
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/glog-support-stacktrace-for-aarch64.patch
2 files changed, 153 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/15420/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8ca769b2bef5fa658d56d11b7ac9537fd9ca637
Gerrit-Change-Number: 15420
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>

[kudu-CR] KUDU-3072 Add glog patch to support stacktrace for aarch64

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15420 )

Change subject: KUDU-3072 Add glog patch to support stacktrace for aarch64
......................................................................


Patch Set 2: Verified+1 Code-Review+2

> @Grant Henke
> I have proposed an pr to google/glog, but no none review it by now :(
> https://github.com/google/glog/pull/529

Could you link to that PR in this commit message?


-- 
To view, visit http://gerrit.cloudera.org:8080/15420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8ca769b2bef5fa658d56d11b7ac9537fd9ca637
Gerrit-Change-Number: 15420
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Mar 2020 18:26:37 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3072 Add glog patch to support stacktrace for aarch64

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15420 )

Change subject: KUDU-3072 Add glog patch to support stacktrace for aarch64
......................................................................

KUDU-3072 Add glog patch to support stacktrace for aarch64

According to the comments in glog-0.3.5/src/utilities.h,
there are three different ways we can try to get the stack trace:
1) The libunwind library
2) Our hand-coded stack-unwinder
3) The gdb unwinder

We use first way to get stack trace by default, the function
"GetStackTrace" is defined in stacktrace_libunwind-inl.h, but
it doesn't work for aarch64, this changes to use the
implementation of aarch64 which defined in
stacktrace_aarch64-inl.h no matter libunwind exist or not.

I have proposed a PR to google/glog:
github.com/google/glog/pull/529

Change-Id: Ia8ca769b2bef5fa658d56d11b7ac9537fd9ca637
Reviewed-on: http://gerrit.cloudera.org:8080/15420
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/glog-support-stacktrace-for-aarch64.patch
2 files changed, 153 insertions(+), 1 deletion(-)

Approvals:
  Grant Henke: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8ca769b2bef5fa658d56d11b7ac9537fd9ca637
Gerrit-Change-Number: 15420
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-3072 Add glog patch to support stacktrace for aarch64

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
huangtianhua223@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/15420 )

Change subject: KUDU-3072 Add glog patch to support stacktrace for aarch64
......................................................................


Patch Set 2:

Sure, I will add the link.


-- 
To view, visit http://gerrit.cloudera.org:8080/15420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8ca769b2bef5fa658d56d11b7ac9537fd9ca637
Gerrit-Change-Number: 15420
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Mar 2020 01:37:45 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3072 Add glog patch to support stacktrace for aarch64

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15420 )

Change subject: KUDU-3072 Add glog patch to support stacktrace for aarch64
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15420/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15420/1//COMMIT_MSG@7
PS1, Line 7: KUDU-3072 Add glog patch to support stacktrace for aarch64
Could you add a note here about how this patch overrides glog's preference of libunwind in favor of the built-in stacktrace support when building on aarch64?



-- 
To view, visit http://gerrit.cloudera.org:8080/15420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8ca769b2bef5fa658d56d11b7ac9537fd9ca637
Gerrit-Change-Number: 15420
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 12 Mar 2020 23:42:34 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3072 Add glog patch to support stacktrace for aarch64

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15420

to look at the new patch set (#2).

Change subject: KUDU-3072 Add glog patch to support stacktrace for aarch64
......................................................................

KUDU-3072 Add glog patch to support stacktrace for aarch64

According to the comments in glog-0.3.5/src/utilities.h,
there are three different ways we can try to get the stack trace:
1) The libunwind library
2) Our hand-coded stack-unwinder
3) The gdb unwinder

We use first way to get stack trace by default, the function
"GetStackTrace" is defined in stacktrace_libunwind-inl.h, but
it doesn't work for aarch64, this changes to use the
implementation of aarch64 which defined in
stacktrace_aarch64-inl.h no matter libunwind exist or not.

Change-Id: Ia8ca769b2bef5fa658d56d11b7ac9537fd9ca637
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/glog-support-stacktrace-for-aarch64.patch
2 files changed, 153 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/15420/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia8ca769b2bef5fa658d56d11b7ac9537fd9ca637
Gerrit-Change-Number: 15420
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-3072 Add glog patch to support stacktrace for aarch64

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15420 )

Change subject: KUDU-3072 Add glog patch to support stacktrace for aarch64
......................................................................


Patch Set 1:

Is this patch committed to glog? Could you add a link to the source of the patch?


-- 
To view, visit http://gerrit.cloudera.org:8080/15420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8ca769b2bef5fa658d56d11b7ac9537fd9ca637
Gerrit-Change-Number: 15420
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 12 Mar 2020 14:54:10 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3072 Add glog patch to support stacktrace for aarch64

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
huangtianhua223@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/15420 )

Change subject: KUDU-3072 Add glog patch to support stacktrace for aarch64
......................................................................


Patch Set 1:

@Grant Henke
I have proposed an pr to google/glog, but no none review it by now :(
https://github.com/google/glog/pull/529


-- 
To view, visit http://gerrit.cloudera.org:8080/15420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8ca769b2bef5fa658d56d11b7ac9537fd9ca637
Gerrit-Change-Number: 15420
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 13 Mar 2020 01:54:59 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3072 Add glog patch to support stacktrace for aarch64

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15420 )

Change subject: KUDU-3072 Add glog patch to support stacktrace for aarch64
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8ca769b2bef5fa658d56d11b7ac9537fd9ca637
Gerrit-Change-Number: 15420
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Mar 2020 01:44:18 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3072 Add glog patch to support stacktrace for aarch64

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15420

to look at the new patch set (#3).

Change subject: KUDU-3072 Add glog patch to support stacktrace for aarch64
......................................................................

KUDU-3072 Add glog patch to support stacktrace for aarch64

According to the comments in glog-0.3.5/src/utilities.h,
there are three different ways we can try to get the stack trace:
1) The libunwind library
2) Our hand-coded stack-unwinder
3) The gdb unwinder

We use first way to get stack trace by default, the function
"GetStackTrace" is defined in stacktrace_libunwind-inl.h, but
it doesn't work for aarch64, this changes to use the
implementation of aarch64 which defined in
stacktrace_aarch64-inl.h no matter libunwind exist or not.

I have proposed a PR to google/glog:
github.com/google/glog/pull/529

Change-Id: Ia8ca769b2bef5fa658d56d11b7ac9537fd9ca637
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/glog-support-stacktrace-for-aarch64.patch
2 files changed, 153 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/15420/3
-- 
To view, visit http://gerrit.cloudera.org:8080/15420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia8ca769b2bef5fa658d56d11b7ac9537fd9ca637
Gerrit-Change-Number: 15420
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)