You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mina.apache.org by GitBox <gi...@apache.org> on 2020/09/21 14:37:53 UTC

[GitHub] [mina-sshd] gnodet edited a comment on pull request #166: [SSHD-1070] Limit the amount of data that is kept in memory for forwa…

gnodet edited a comment on pull request #166:
URL: https://github.com/apache/mina-sshd/pull/166#issuecomment-695931866


   @fengjiajie yes, unfortunately, the test was missing some assumptions.  I've seen it pass when there were errors in the transmission.  I've fixed the test in master. 
   However, the result is that I can't make it pass since https://github.com/apache/mina-sshd/commit/45f84aab59b2e11d72942cffe9d810e37ab64959 so I'm thinking about somehow reverting this commit and enabling those tests by default in a first pass.  It seems the problem comes from the `ChannelAsyncOutputStream`, but I haven't been able to find out where.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org