You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2026/06/07 18:58:22 UTC
[PR] Only conditionally include anchor js and gh-ribbon css [maven-fluido-skin]
kwin opened a new pull request, #335:
URL: https://github.com/apache/maven-fluido-skin/pull/335
Minify separately
Bump minimum doxia-sitetools requirement to 2.1.0
This closes #327
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Your pull request should address just one issue, without pulling in other changes.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
- [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [ ] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Only conditionally include anchor js, gh-ribbon css and profile background images [maven-fluido-skin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #335:
URL: https://github.com/apache/maven-fluido-skin/pull/335#issuecomment-4646535933
@kwin what with Jenkins build ... looks like affected by the same issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Only conditionally include anchor js, gh-ribbon css and profile background images [maven-fluido-skin]
Posted by "slachiewicz (via GitHub) via issues" <is...@maven.apache.org>.
slachiewicz merged PR #335:
URL: https://github.com/apache/maven-fluido-skin/pull/335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Only conditionally include anchor js, gh-ribbon css and profile background images [maven-fluido-skin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #335:
URL: https://github.com/apache/maven-fluido-skin/pull/335#issuecomment-5721337189
We heve site plugin https://github.com/apache/maven-site-plugin/releases/tag/maven-site-plugin-3.22.0 can we finish it ...?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Only conditionally include anchor js, gh-ribbon css and profile background images [maven-fluido-skin]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #335:
URL: https://github.com/apache/maven-fluido-skin/pull/335#issuecomment-5725440149
I didn't yet find the time to test it properly...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Only conditionally include anchor js, gh-ribbon css and profile background images [maven-fluido-skin]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #335:
URL: https://github.com/apache/maven-fluido-skin/pull/335#issuecomment-4646919534
Jenkins pipeline needs to be tweaked here: https://github.com/apache/maven-jenkins-lib/blob/ca95acbebabbc4a4962d685360d861134b913df8/vars/asfMavenTlpStdBuild.groovy#L105 as described in https://www.jenkins.io/doc/pipeline/steps/params/scmgit/#scmgit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Only conditionally include anchor js, gh-ribbon css and profile background images [maven-fluido-skin]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #335:
URL: https://github.com/apache/maven-fluido-skin/pull/335#issuecomment-4646411760
The build currently fails due to https://github.com/apache/maven-scm/issues/1378. I raised https://github.com/apache/maven-gh-actions-shared/issues/264 to allow to disable shallow cloning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Only conditionally include anchor js, gh-ribbon css and profile background images [maven-fluido-skin]
Posted by "slachiewicz (via GitHub) via issues" <is...@maven.apache.org>.
slachiewicz commented on PR #335:
URL: https://github.com/apache/maven-fluido-skin/pull/335#issuecomment-6548682490
Rebased on master and added two commits: a resource condition is copied only when it renders `true`, so the plain expressions never matched; `${anchorjs.version}` is not filtered in `skin.xml`; and the ribbon stylesheet is packaged as `gh-fork-ribbon.min.css` but was linked as `gh-fork-ribbon.css` on every page. The ITs `mskins-16`, `-22`, `-23` and `-226-anchorjs-options` now check what is linked and copied. `dark-theme.css` from #325 is conditional too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org