[GitHub] [commons-compress] PeterAlfreadLee commented on issue #87: COMPRESS-124 : Add support for extracting sparse entries from tar archives

[GitBox <gi...@apache.org>]

PeterAlfreadLee commented on issue #87: COMPRESS-124 : Add support for extracting sparse entries from tar archives
URL: https://github.com/apache/commons-compress/pull/87#issuecomment-571408454
 
 
   > I'm wondering whether we really want to make the API details public or whether things like the getters and setters for sparse headers in TarArchiveEntry should be hidden instead. As a matter of taste I would have preferred TarArchiveStructSparse to be immutable and have no setters at all.
   
   +1
   
   For `TarArchiveEntry`, I have the same feeling that the details(getters/setters) should be hidden when I was reading the code.
   
   For `TarArchiveStructSparse`, I agree that it should be immutable. I will modify this and push another PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services