You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2013/03/14 01:20:19 UTC
Review Request: FLUME-1947. ExecSource should optionally block if the
channel is full.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9914/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Made multiple changes to the exec source:
1. Flush the events to the channel, based on a configurable timeout - even when a full batch was not received.
2. Block the spawned process until channel exceptions are cleared up by not reading the stdout buffer. Backoff exponentially (subject to an upper limit), till events are available.
This addresses bug FLUME-1947.
https://issues.apache.org/jira/browse/FLUME-1947
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java 8e687f2
flume-ng-core/src/main/java/org/apache/flume/source/ExecSourceConfigurationConstants.java fd5a60b
flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 7c573f6
Diff: https://reviews.apache.org/r/9914/diff/
Testing
-------
Added unit tests for the new features. All current tests pass.
Thanks,
Hari Shreedharan
Re: Review Request 9914: FLUME-1947. ExecSource should optionally block if
the channel is full.
Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9914/#review23299
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Alten-Lorenz
On June 18, 2013, 8:05 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9914/
> -----------------------------------------------------------
>
> (Updated June 18, 2013, 8:05 p.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-1947
> https://issues.apache.org/jira/browse/FLUME-1947
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Made multiple changes to the exec source:
>
> 1. Flush the events to the channel, based on a configurable timeout - even when a full batch was not received.
> 2. Block the spawned process until channel exceptions are cleared up by not reading the stdout buffer. Backoff exponentially (subject to an upper limit), till events are available.
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java 1d8d267
> flume-ng-core/src/main/java/org/apache/flume/source/ExecSourceConfigurationConstants.java 957ec7f
> flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 54f71a1
>
> Diff: https://reviews.apache.org/r/9914/diff/
>
>
> Testing
> -------
>
> Added unit tests for the new features. All current tests pass.
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1947. ExecSource should optionally block if the
channel is full.
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9914/
-----------------------------------------------------------
(Updated June 18, 2013, 8:05 p.m.)
Review request for Flume.
Changes
-------
Reworked the patch to remove the flushing automatically changes since it has already been committed.
Description
-------
Made multiple changes to the exec source:
1. Flush the events to the channel, based on a configurable timeout - even when a full batch was not received.
2. Block the spawned process until channel exceptions are cleared up by not reading the stdout buffer. Backoff exponentially (subject to an upper limit), till events are available.
This addresses bug FLUME-1947.
https://issues.apache.org/jira/browse/FLUME-1947
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java 1d8d267
flume-ng-core/src/main/java/org/apache/flume/source/ExecSourceConfigurationConstants.java 957ec7f
flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 54f71a1
Diff: https://reviews.apache.org/r/9914/diff/
Testing
-------
Added unit tests for the new features. All current tests pass.
Thanks,
Hari Shreedharan