[jira] [Commented] (MCHECKSTYLE-366) Upgrade checkstyle to a more recent version

["Enrico Olivelli (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MCHECKSTYLE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16775623#comment-16775623 ] 

Enrico Olivelli commented on MCHECKSTYLE-366:
---------------------------------------------

Actually the problem is due that recent versions of checkstyle require Java 8

[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-bytecode-version) @ maven-checkstyle-plugin ---
[INFO] Restricted to JDK 1.7 yet org.checkerframework:checker-qual:jar:2.5.2:compile contains org/checkerframework/dataflow/qual/Pure$Kind.class targeted to JDK 1.8
[INFO] Restricted to JDK 1.7 yet com.google.guava:guava:jar:27.0.1-jre:compile contains com/google/common/annotations/Beta.class targeted to JDK 1.8
[INFO] Restricted to JDK 1.7 yet net.sf.saxon:Saxon-HE:jar:9.9.0-2:compile contains net/sf/saxon/BasicTransformerFactory.class targeted to JDK 1.8
[INFO] Restricted to JDK 1.7 yet com.puppycrawl.tools:checkstyle:jar:8.17:compile contains com/puppycrawl/tools/checkstyle/PropertyResolver.class targeted to JDK 1.8
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.EnforceBytecodeVersion failed with message:
Found Banned Dependency: org.checkerframework:checker-qual:jar:2.5.2
Found Banned Dependency: com.google.guava:guava:jar:27.0.1-jre
Found Banned Dependency: net.sf.saxon:Saxon-HE:jar:9.9.0-2
Found Banned Dependency: com.puppycrawl.tools:checkstyle:jar:8.17
Use 'mvn dependency:tree' to locate the source of the banned dependencies.

 

> Upgrade checkstyle to a more recent version
> -------------------------------------------
>
>                 Key: MCHECKSTYLE-366
>                 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-366
>             Project: Maven Checkstyle Plugin
>          Issue Type: Dependency upgrade
>    Affects Versions: 3.0.0
>            Reporter: Olivier Grégoire
>            Assignee: Enrico Olivelli
>            Priority: Major
>
> Version 3.0.0 still uses checkstyle 6.18.
>  
> The google_checks.xml of 6.18 contains a rule that says "com.google" imports must be first. This was [removed in 2016|https://github.com/checkstyle/checkstyle/commit/81ad4595fe3a916551d73e467044c87d8462dba6#diff-c55cd603ef6597463971db3f33f4f4c8] yet the latest version of checkstyle (3.0.0 of January 2018) still says I should use that version of 2016 which has the dummy rule that com.google imports should come first.
>  
> I know it's overridable, but the bottom line is that checkstyle relies on an really outdated version of checkstyle which has total nonsense in it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)