[jira] [Commented] (SAMZA-1640) JobModel Json deserialization error in ZkJobCoordinator

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429017#comment-16429017 ] 

ASF GitHub Bot commented on SAMZA-1640:
---------------------------------------

GitHub user shanthoosh opened a pull request:

    https://github.com/apache/samza/pull/466

    SAMZA-1640: JobModel Json deserialization error in ZkJobCoordinator.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shanthoosh/samza SAMZA-1640

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/466.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #466
    
----
commit 420cf6cef95a95baa00dc001844395bef137b662
Author: Shanthoosh Venkataraman <sv...@...>
Date:   2018-04-06T20:46:34Z

    SAMZA-1640: JobModel Json deserialization error in standalone.

----


> JobModel Json deserialization error in ZkJobCoordinator
> -------------------------------------------------------
>
>                 Key: SAMZA-1640
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1640
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Shanthoosh Venkataraman
>            Assignee: Shanthoosh Venkataraman
>            Priority: Major
>
> *Problem:*
> JobModel deserialization in ZkJobCoordinator throws the following exception in some scenarios.
> {code:java}
> org.codehaus.jackson.map.exc.UnrecognizedPropertyException: Unrecognized field "task-partition-mappings" (Class org.apache.samza.job.model.JobModel), not marked as ignorable at [Source: java.io.StringReader@1f7030a6; line: 1, column: 315] (through reference chain: org.apache.samza.job.model.JobModel["task-partition-mappings"]) at org.codehaus.jackson.map.exc.UnrecognizedPropertyException.from(UnrecognizedPropertyException.java:53) at org.codehaus.jackson.map.deser.StdDeserializationContext.unknownFieldException(StdDeserializationContext.java:267) at org.codehaus.jackson.map.deser.std.StdDeserializer.reportUnknownProperty(StdDeserializer.java:673) at org.codehaus.jackson.map.deser.std.StdDeserializer.handleUnknownProperty(StdDeserializer.java:659) at org.codehaus.jackson.map.deser.BeanDeserializer.handleUnknownProperty(BeanDeserializer.java:1365) at org.codehaus.jackson.map.deser.BeanDeserializer.deserialize(BeanDeserializer.java:652) at org.codehaus.jackson.map.deser.BeanDeserializer._deserializeUsingPropertyBased(BeanDeserializer.java:923) at org.codehaus.jackson.map.deser.BeanDeserializer.deserializeFromObjectUsingNonDefault(BeanDeserializer.java:739) at org.codehaus.jackson.map.deser.BeanDeserializer.deserializeFromObject(BeanDeserializer.java:683) at org.codehaus.jackson.map.deser.BeanDeserializer.deserialize(BeanDeserializer.java:580) at 
> org.codehaus.jackson.map.ObjectMapper._readMapAndClose(ObjectMapper.java:2732) at 
> org.codehaus.jackson.map.ObjectMapper.readValue(ObjectMapper.java:1863) at 
> {code}
> *Reason:*
> We started storing the field 'task-partition-mappings' in JobModel after SAMZA-1555.
> Above exception occurs when we try to deserialize the new JobModel format with the old JobModel deserilization code(vice-versa).
> Potentially can occur during rolling bounce upgrade/canary scenarios in standalone.
> *Fix:* 
>  A. Exclude task-partition-mappings field in deserialization/serialization path. `task-partition-mappings` is derived out of the containers field in JobModel. It doesn't add value to store it in JobModel.
> B. Fix the test testContainerModelCompatible in TestSamzaObjectMapper which was supposed to validate this scenario.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)