You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/01/16 15:47:42 UTC
[GitHub] [drill] vdiravka opened a new pull request #2429: DRILL-8107: Hadoop2 backport Maven profile
vdiravka opened a new pull request #2429:
URL: https://github.com/apache/drill/pull/2429
- Adding new profile along with needed dependencies and their exclusions
- Increase jdbc-all jar file size for hadoop-2 profile
- Patch Guava Futures addCallback
# [DRILL-8107](https://issues.apache.org/jira/browse/DRILL-8107): Hadoop2 backport Maven profile
## Description
Some Drill clients are stuck on the old Hadoop2 cluster version. To run the latest version of Drill, need to add a Maven profile to build Drill for that environment.
## Documentation
Just enable `hadoop-2` Maven profile to build Hadoop2 compatible distribution
## Testing
All unit tests pass with enabled `hadoop-2` profile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] jnturton edited a comment on pull request #2429: DRILL-8107: Hadoop2 backport Maven profile
Posted by GitBox <gi...@apache.org>.
jnturton edited a comment on pull request #2429:
URL: https://github.com/apache/drill/pull/2429#issuecomment-1014342585
@cgivre I've just added instructions for using this profile to
https://drill.apache.org/docs/compiling-drill-from-source/
. Well, I thought I had. Something's wrong with the website CI for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vvysotskyi commented on a change in pull request #2429: DRILL-8107: Hadoop2 backport Maven profile
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on a change in pull request #2429:
URL: https://github.com/apache/drill/pull/2429#discussion_r785462370
##########
File path: exec/jdbc-all/pom.xml
##########
@@ -874,6 +874,42 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>hadoop-2</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>enforce-jdbc-jar-compactness</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <phase>verify</phase>
+ <configuration>
+ <rules>
+ <requireFilesSize>
+ <message>
+ The file drill-jdbc-all-${project.version}.jar is outside the expected size range.
+ This is likely due to you adding new dependencies to a java-exec and not updating the excludes in this module. This is important as it minimizes the size of the dependency of Drill application users.
+ </message>
+ <maxsize>47600000</maxsize>
Review comment:
If plugin configs have only different `maxsize`, you can define it as a property and set that property value in the profile instead of providing plugin configs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on pull request #2429: DRILL-8107: Hadoop2 backport Maven profile
Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2429:
URL: https://github.com/apache/drill/pull/2429#issuecomment-1013901708
@vdiravka Thanks for submitting this. Would you mind showing exactly what someone has to do to build Drill with Hadoop 2 in the docs? Like the exact Maven command?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vdiravka commented on a change in pull request #2429: DRILL-8107: Hadoop2 backport Maven profile
Posted by GitBox <gi...@apache.org>.
vdiravka commented on a change in pull request #2429:
URL: https://github.com/apache/drill/pull/2429#discussion_r786851263
##########
File path: exec/jdbc-all/pom.xml
##########
@@ -874,6 +874,42 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>hadoop-2</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>enforce-jdbc-jar-compactness</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <phase>verify</phase>
+ <configuration>
+ <rules>
+ <requireFilesSize>
+ <message>
+ The file drill-jdbc-all-${project.version}.jar is outside the expected size range.
+ This is likely due to you adding new dependencies to a java-exec and not updating the excludes in this module. This is important as it minimizes the size of the dependency of Drill application users.
+ </message>
+ <maxsize>47600000</maxsize>
Review comment:
Agree with all. Property is added and `## drill-jdbc-all JAR maxsize` doc header is added in `docs/dev/Maven.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] jnturton commented on a change in pull request #2429: DRILL-8107: Hadoop2 backport Maven profile
Posted by GitBox <gi...@apache.org>.
jnturton commented on a change in pull request #2429:
URL: https://github.com/apache/drill/pull/2429#discussion_r786005734
##########
File path: exec/jdbc-all/pom.xml
##########
@@ -874,6 +874,42 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>hadoop-2</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>enforce-jdbc-jar-compactness</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <phase>verify</phase>
+ <configuration>
+ <rules>
+ <requireFilesSize>
+ <message>
+ The file drill-jdbc-all-${project.version}.jar is outside the expected size range.
+ This is likely due to you adding new dependencies to a java-exec and not updating the excludes in this module. This is important as it minimizes the size of the dependency of Drill application users.
+ </message>
+ <maxsize>47600000</maxsize>
Review comment:
Sounds like something that we should make a property anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] jnturton commented on pull request #2429: DRILL-8107: Hadoop2 backport Maven profile
Posted by GitBox <gi...@apache.org>.
jnturton commented on pull request #2429:
URL: https://github.com/apache/drill/pull/2429#issuecomment-1014548764
@vdiravka am I right that our CI builds won't test the new hadoop-2 profile automatically?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on a change in pull request #2429: DRILL-8107: Hadoop2 backport Maven profile
Posted by GitBox <gi...@apache.org>.
cgivre commented on a change in pull request #2429:
URL: https://github.com/apache/drill/pull/2429#discussion_r786802924
##########
File path: exec/jdbc-all/pom.xml
##########
@@ -874,6 +874,42 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>hadoop-2</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>enforce-jdbc-jar-compactness</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <phase>verify</phase>
+ <configuration>
+ <rules>
+ <requireFilesSize>
+ <message>
+ The file drill-jdbc-all-${project.version}.jar is outside the expected size range.
+ This is likely due to you adding new dependencies to a java-exec and not updating the excludes in this module. This is important as it minimizes the size of the dependency of Drill application users.
+ </message>
+ <maxsize>47600000</maxsize>
Review comment:
Could we add something to the developer docs as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] jnturton merged pull request #2429: DRILL-8107: Hadoop2 backport Maven profile
Posted by GitBox <gi...@apache.org>.
jnturton merged pull request #2429:
URL: https://github.com/apache/drill/pull/2429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] jnturton commented on pull request #2429: DRILL-8107: Hadoop2 backport Maven profile
Posted by GitBox <gi...@apache.org>.
jnturton commented on pull request #2429:
URL: https://github.com/apache/drill/pull/2429#issuecomment-1014342585
@cgivre I've just added instructions for using this profile to
https://drill.apache.org/docs/compiling-drill-from-source/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vdiravka commented on a change in pull request #2429: DRILL-8107: Hadoop2 backport Maven profile
Posted by GitBox <gi...@apache.org>.
vdiravka commented on a change in pull request #2429:
URL: https://github.com/apache/drill/pull/2429#discussion_r786851263
##########
File path: exec/jdbc-all/pom.xml
##########
@@ -874,6 +874,42 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>hadoop-2</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>enforce-jdbc-jar-compactness</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <phase>verify</phase>
+ <configuration>
+ <rules>
+ <requireFilesSize>
+ <message>
+ The file drill-jdbc-all-${project.version}.jar is outside the expected size range.
+ This is likely due to you adding new dependencies to a java-exec and not updating the excludes in this module. This is important as it minimizes the size of the dependency of Drill application users.
+ </message>
+ <maxsize>47600000</maxsize>
Review comment:
Agree with all. Property is added and `## drill-jdbc-all JAR maxsize` doc header is added to `docs/dev/Maven.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org