You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "Cole-Greer (via GitHub)" <gi...@apache.org> on 2024/09/04 02:01:14 UTC
[PR] Fix console integration tests [tinkerpop]
Cole-Greer opened a new pull request, #2759:
URL: https://github.com/apache/tinkerpop/pull/2759
I noticed that the gremlin console integration tests were all failing due changes in the plugin activation text in the console header. This PR simply fixes the tests by updating it to reflect the plugins which are currently loaded by default. Consideration into which plugins should be activated by default may be warranted.
The current console header looks like this:
```
\,,,/
(o o)
-----oOOo-(3)-oOOo-----
plugin activated: tinkerpop.remote
plugin activated: tinkerpop.utilities
plugin activated: tinkerpop.sugar
plugin activated: tinkerpop.credentials
plugin activated: tinkerpop.tinkergraph
gremlin>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix console integration tests [tinkerpop]
Posted by "andreachild (via GitHub)" <gi...@apache.org>.
andreachild commented on PR #2759:
URL: https://github.com/apache/tinkerpop/pull/2759#issuecomment-2327886026
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix console integration tests [tinkerpop]
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #2759:
URL: https://github.com/apache/tinkerpop/pull/2759#issuecomment-2329595562
Update: I noticed an unexpected issue where when running the console integration tests locally, my console was loading all 5 plugins mentioned above, however when running the integration tests in github actions, `test_basic_console_operations` was failing as the `sugar` and `credentials` plugins were not found in the console output. I have pulled the expect statements for those plugins out of the PR, and now the only change being reflected in the tests is a renaming of `tinkerpop.server` to `tinkerpop.remote`.
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix console integration tests [tinkerpop]
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer merged PR #2759:
URL: https://github.com/apache/tinkerpop/pull/2759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix console integration tests [tinkerpop]
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #2759:
URL: https://github.com/apache/tinkerpop/pull/2759#issuecomment-2329557812
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix console integration tests [tinkerpop]
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #2759:
URL: https://github.com/apache/tinkerpop/pull/2759#issuecomment-2327887883
VOTE+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org