You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by we...@apache.org on 2015/12/22 23:22:19 UTC
reef git commit: [REEF-1106/1107/1110/1111] Enable exception-handling
checkstyle checks with no violations
Repository: reef
Updated Branches:
refs/heads/master d6b316925 -> 275a08a91
[REEF-1106/1107/1110/1111] Enable exception-handling checkstyle checks with no violations
This change enables the following checks which have no violations in our code:
* MutableException
* ForbidReturnInFinallyBlockCheck
* ForbidThrowAnonymousExceptionsCheck
* UselessSingleCatchCheck
JIRA:
[REEF-1106](https://issues.apache.org/jira/browse/REEF-1106)
[REEF-1107](https://issues.apache.org/jira/browse/REEF-1107)
[REEF-1110](https://issues.apache.org/jira/browse/REEF-1110)
[REEF-1111](https://issues.apache.org/jira/browse/REEF-1111)
Pull request:
This closes #748
Project: http://git-wip-us.apache.org/repos/asf/reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/reef/commit/275a08a9
Tree: http://git-wip-us.apache.org/repos/asf/reef/tree/275a08a9
Diff: http://git-wip-us.apache.org/repos/asf/reef/diff/275a08a9
Branch: refs/heads/master
Commit: 275a08a91b6a4012493ca952ce1c7ebb8abf0b0b
Parents: d6b3169
Author: Mariia Mykhailova <ma...@apache.org>
Authored: Tue Dec 22 11:55:27 2015 -0800
Committer: Markus Weimer <we...@apache.org>
Committed: Tue Dec 22 14:21:38 2015 -0800
----------------------------------------------------------------------
.../java/reef-common/src/main/resources/checkstyle-strict.xml | 7 +++++++
lang/java/reef-common/src/main/resources/checkstyle.xml | 7 +++++++
2 files changed, 14 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/reef/blob/275a08a9/lang/java/reef-common/src/main/resources/checkstyle-strict.xml
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/resources/checkstyle-strict.xml b/lang/java/reef-common/src/main/resources/checkstyle-strict.xml
index ad2b485..7502d00 100644
--- a/lang/java/reef-common/src/main/resources/checkstyle-strict.xml
+++ b/lang/java/reef-common/src/main/resources/checkstyle-strict.xml
@@ -216,6 +216,13 @@
<property name="format" value="TODO\[JIRA"/>
</module>
<module name="UpperEll"/>
+
+ <!-- Exception-handling checks. -->
+ <!-- See https://issues.apache.org/jira/browse/REEF-864 -->
+ <module name="MutableException"/>
+ <module name="ForbidReturnInFinallyBlockCheck"/>
+ <module name="ForbidThrowAnonymousExceptionsCheck"/>
+ <module name="UselessSingleCatchCheck"/>
</module>
</module>
http://git-wip-us.apache.org/repos/asf/reef/blob/275a08a9/lang/java/reef-common/src/main/resources/checkstyle.xml
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/resources/checkstyle.xml b/lang/java/reef-common/src/main/resources/checkstyle.xml
index 62694c4..b3d0539 100644
--- a/lang/java/reef-common/src/main/resources/checkstyle.xml
+++ b/lang/java/reef-common/src/main/resources/checkstyle.xml
@@ -218,6 +218,13 @@
<property name="format" value="TODO\[JIRA"/>
</module>
<module name="UpperEll"/>
+
+ <!-- Exception-handling checks. -->
+ <!-- See https://issues.apache.org/jira/browse/REEF-864 -->
+ <module name="MutableException"/>
+ <module name="ForbidReturnInFinallyBlockCheck"/>
+ <module name="ForbidThrowAnonymousExceptionsCheck"/>
+ <module name="UselessSingleCatchCheck"/>
</module>
</module>