You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ian Duffy <ia...@ianduffy.ie> on 2013/07/26 15:52:10 UTC
Review Request 12969: Complete LDAP user provisioning UI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12969/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek, Pranav Saxena, and Sebastien Goasguen.
Repository: cloudstack-git
Description
-------
Completes the task for adding LDAP user provisioning UI features.
This inlcudes:
Add accounts -> add account
Table of user accounts within LDAP appears.
Admin selects user and can add.
An admin has the ability to select multiple users.
This add screen will only appear when ldap is enabled.
Diffs
-----
plugins/user-authenticators/ldap/test/resources/cloudstack.org.ldif b20de81
ui/css/cloudstack3.css 93658db
ui/index.jsp 813dbcb
ui/scripts/accounts.js e3e28e4
ui/scripts/accountsWizard.js a350085
ui/scripts/sharedFunctions.js 6c1b009
ui/scripts/ui-custom/accountsWizard.js 4037788
Diff: https://reviews.apache.org/r/12969/diff/
Testing
-------
All testing was done manually
Create a single account when ldap is enabled.
create multiple accounts when ldap is enabled.
create a single account when ldap is disabled.
Thanks,
Ian Duffy
Re: Review Request 12969: Complete LDAP user provisioning UI.
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12969/#review24105
-----------------------------------------------------------
Ship it!
shipped to ldapplugin ec064b307734dcb1d4304454de466d6e70e019fb
close as submitted
- Sebastien Goasguen
On July 26, 2013, 4:13 p.m., Ian Duffy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12969/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 4:13 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Pranav Saxena, and Sebastien Goasguen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Completes the task for adding LDAP user provisioning UI features.
>
> This inlcudes:
> Add accounts -> add account
> Table of user accounts within LDAP appears.
> Admin selects user and can add.
> An admin has the ability to select multiple users.
>
> This add screen will only appear when ldap is enabled.
>
>
> Diffs
> -----
>
> plugins/user-authenticators/ldap/test/resources/cloudstack.org.ldif b20de81
> ui/css/cloudstack3.css 93658db
> ui/index.jsp 813dbcb
> ui/scripts/accounts.js e3e28e4
> ui/scripts/accountsWizard.js a350085
> ui/scripts/sharedFunctions.js 6c1b009
> ui/scripts/ui-custom/accountsWizard.js 4037788
>
> Diff: https://reviews.apache.org/r/12969/diff/
>
>
> Testing
> -------
>
> All testing was done manually
>
> Create a single account when ldap is enabled.
> create multiple accounts when ldap is enabled.
>
> create a single account when ldap is disabled.
>
>
> Thanks,
>
> Ian Duffy
>
>
Re: Review Request 12969: Complete LDAP user provisioning UI.
Posted by Ian Duffy <ia...@ianduffy.ie>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12969/
-----------------------------------------------------------
(Updated July 26, 2013, 4:13 p.m.)
Review request for cloudstack, Abhinandan Prateek, Pranav Saxena, and Sebastien Goasguen.
Changes
-------
Fix slight bug with domainid not being set with ldap enabled.
Repository: cloudstack-git
Description
-------
Completes the task for adding LDAP user provisioning UI features.
This inlcudes:
Add accounts -> add account
Table of user accounts within LDAP appears.
Admin selects user and can add.
An admin has the ability to select multiple users.
This add screen will only appear when ldap is enabled.
Diffs (updated)
-----
plugins/user-authenticators/ldap/test/resources/cloudstack.org.ldif b20de81
ui/css/cloudstack3.css 93658db
ui/index.jsp 813dbcb
ui/scripts/accounts.js e3e28e4
ui/scripts/accountsWizard.js a350085
ui/scripts/sharedFunctions.js 6c1b009
ui/scripts/ui-custom/accountsWizard.js 4037788
Diff: https://reviews.apache.org/r/12969/diff/
Testing
-------
All testing was done manually
Create a single account when ldap is enabled.
create multiple accounts when ldap is enabled.
create a single account when ldap is disabled.
Thanks,
Ian Duffy
Re: Review Request 12969: Complete LDAP user provisioning UI.
Posted by Ian Duffy <ia...@ianduffy.ie>.
> On July 26, 2013, 1:57 p.m., Jenkins Cloudstack.org wrote:
> > Review 12969 failed the build test : FAILURE
> > The url of build cloudstack-master-with-patch #51 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/51/
Please note jenkins attempts to apply this patch to the master branch. This patch is for the ldapplugin branch.
- Ian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12969/#review23949
-----------------------------------------------------------
On July 26, 2013, 1:52 p.m., Ian Duffy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12969/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 1:52 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Pranav Saxena, and Sebastien Goasguen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Completes the task for adding LDAP user provisioning UI features.
>
> This inlcudes:
> Add accounts -> add account
> Table of user accounts within LDAP appears.
> Admin selects user and can add.
> An admin has the ability to select multiple users.
>
> This add screen will only appear when ldap is enabled.
>
>
> Diffs
> -----
>
> plugins/user-authenticators/ldap/test/resources/cloudstack.org.ldif b20de81
> ui/css/cloudstack3.css 93658db
> ui/index.jsp 813dbcb
> ui/scripts/accounts.js e3e28e4
> ui/scripts/accountsWizard.js a350085
> ui/scripts/sharedFunctions.js 6c1b009
> ui/scripts/ui-custom/accountsWizard.js 4037788
>
> Diff: https://reviews.apache.org/r/12969/diff/
>
>
> Testing
> -------
>
> All testing was done manually
>
> Create a single account when ldap is enabled.
> create multiple accounts when ldap is enabled.
>
> create a single account when ldap is disabled.
>
>
> Thanks,
>
> Ian Duffy
>
>
Re: Review Request 12969: Complete LDAP user provisioning UI.
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12969/#review23949
-----------------------------------------------------------
Review 12969 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #51 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/51/
- Jenkins Cloudstack.org
On July 26, 2013, 1:52 p.m., Ian Duffy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12969/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 1:52 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Pranav Saxena, and Sebastien Goasguen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Completes the task for adding LDAP user provisioning UI features.
>
> This inlcudes:
> Add accounts -> add account
> Table of user accounts within LDAP appears.
> Admin selects user and can add.
> An admin has the ability to select multiple users.
>
> This add screen will only appear when ldap is enabled.
>
>
> Diffs
> -----
>
> plugins/user-authenticators/ldap/test/resources/cloudstack.org.ldif b20de81
> ui/css/cloudstack3.css 93658db
> ui/index.jsp 813dbcb
> ui/scripts/accounts.js e3e28e4
> ui/scripts/accountsWizard.js a350085
> ui/scripts/sharedFunctions.js 6c1b009
> ui/scripts/ui-custom/accountsWizard.js 4037788
>
> Diff: https://reviews.apache.org/r/12969/diff/
>
>
> Testing
> -------
>
> All testing was done manually
>
> Create a single account when ldap is enabled.
> create multiple accounts when ldap is enabled.
>
> create a single account when ldap is disabled.
>
>
> Thanks,
>
> Ian Duffy
>
>