You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by xu...@apache.org on 2024/03/21 12:29:07 UTC
(opendal) branch read_at_based updated: Remove complete
This is an automated email from the ASF dual-hosted git repository.
xuanwo pushed a commit to branch read_at_based
in repository https://gitbox.apache.org/repos/asf/opendal.git
The following commit(s) were added to refs/heads/read_at_based by this push:
new 73076d8059 Remove complete
73076d8059 is described below
commit 73076d8059ff552fe4b785e526314c0f84645680
Author: Xuanwo <gi...@xuanwo.io>
AuthorDate: Thu Mar 21 20:28:55 2024 +0800
Remove complete
Signed-off-by: Xuanwo <gi...@xuanwo.io>
---
core/src/layers/complete.rs | 96 ---------------------------------------------
1 file changed, 96 deletions(-)
diff --git a/core/src/layers/complete.rs b/core/src/layers/complete.rs
index 17f59e8116..d614612ca9 100644
--- a/core/src/layers/complete.rs
+++ b/core/src/layers/complete.rs
@@ -274,92 +274,6 @@ impl<A: Accessor> CompleteAccessor<A> {
})
}
- // async fn complete_read(
- // &self,
- // path: &str,
- // args: OpRead,
- // ) -> Result<(RpRead, CompleteReader<A, A::Reader>)> {
- // let capability = self.meta.native_capability();
- // if !capability.read {
- // return Err(self.new_unsupported_error(Operation::Read));
- // }
- //
- // let seekable = capability.read_can_seek;
- // let streamable = capability.read_can_next;
- // let buffer_cap = args.buffer();
- //
- // let r = match (seekable, streamable) {
- // (true, true) => {
- // let r = LazyReader::new(self.inner.clone(), path, args);
- // InnerCompleteReader::One(r)
- // }
- // (true, false) => {
- // let r = FileReader::new(self.inner.clone(), path, args);
- // InnerCompleteReader::Two(r)
- // }
- // _ => {
- // let r = RangeReader::new(self.inner.clone(), path, args);
- //
- // if streamable {
- // InnerCompleteReader::Three(r)
- // } else {
- // let r = oio::into_streamable_read(r, 256 * 1024);
- // InnerCompleteReader::Four(r)
- // }
- // }
- // };
- //
- // let r = match buffer_cap {
- // None => CompleteReader::One(r),
- // Some(cap) => CompleteReader::Two(BufferReader::new(r, cap)),
- // };
- //
- // Ok((RpRead::new(), r))
- // }
-
- // fn complete_blocking_read(
- // &self,
- // path: &str,
- // args: OpRead,
- // ) -> Result<(RpRead, CompleteReader<A, A::BlockingReader>)> {
- // let capability = self.meta.full_capability();
- // if !capability.read || !capability.blocking {
- // return Err(self.new_unsupported_error(Operation::BlockingRead));
- // }
- //
- // let seekable = capability.read_can_seek;
- // let streamable = capability.read_can_next;
- // let buffer_cap = args.buffer();
- //
- // let r = match (seekable, streamable) {
- // (true, true) => {
- // let r = LazyReader::new(self.inner.clone(), path, args);
- // InnerCompleteReader::One(r)
- // }
- // (true, false) => {
- // let r = FileReader::new(self.inner.clone(), path, args);
- // InnerCompleteReader::Two(r)
- // }
- // _ => {
- // let r = RangeReader::new(self.inner.clone(), path, args);
- //
- // if streamable {
- // InnerCompleteReader::Three(r)
- // } else {
- // let r = oio::into_streamable_read(r, 256 * 1024);
- // InnerCompleteReader::Four(r)
- // }
- // }
- // };
- //
- // let r = match buffer_cap {
- // None => CompleteReader::One(r),
- // Some(cap) => CompleteReader::Two(BufferReader::new(r, cap)),
- // };
- //
- // Ok((RpRead::new(), r))
- // }
-
async fn complete_list(
&self,
path: &str,
@@ -667,16 +581,6 @@ impl<A: Accessor> LayeredAccessor for CompleteAccessor<A> {
}
}
-// pub type CompleteReader<A, R> =
-// TwoWays<InnerCompleteReader<A, R>, BufferReader<InnerCompleteReader<A, R>>>;
-//
-// type InnerCompleteReader<A, R> = FourWays<
-// LazyReader<A, R>,
-// FileReader<A, R>,
-// RangeReader<A, R>,
-// StreamableReader<RangeReader<A, R>>,
-// >;
-
pub type CompleteLister<A, P> =
FourWays<P, FlatLister<Arc<A>, P>, PrefixLister<P>, PrefixLister<FlatLister<Arc<A>, P>>>;