You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2022/04/21 10:34:46 UTC
[GitHub] [systemds] Baunsgaard opened a new pull request, #1593: [SYSTEMDS-3355] MatrixBlock size using CSR when allowed
Baunsgaard opened a new pull request, #1593:
URL: https://github.com/apache/systemds/pull/1593
This PR change/fix the size estimation to correctly use CSR size if that is allowed.
I have artificially limited it to only cases with more than one column,
since we have code paths that exploit the fact that we do not have any sparse single columns.
I personally would like this merged in, but i can see that it potentially reduce performance in some cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] mboehm7 commented on pull request #1593: [SYSTEMDS-3355] MatrixBlock size using CSR when allowed
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on PR #1593:
URL: https://github.com/apache/systemds/pull/1593#issuecomment-1126963410
LGTM - thanks for the patch @Baunsgaard. This is a good improvement of `examSparsity` while preserving the worst-case characteristic of other memory estimates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] asfgit closed pull request #1593: [SYSTEMDS-3355] MatrixBlock size using CSR when allowed
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1593: [SYSTEMDS-3355] MatrixBlock size using CSR when allowed
URL: https://github.com/apache/systemds/pull/1593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] mboehm7 commented on pull request #1593: [SYSTEMDS-3355] MatrixBlock size using CSR when allowed
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on PR #1593:
URL: https://github.com/apache/systemds/pull/1593#issuecomment-1105111388
I'll have a look in the next days - although I would prefer bringing this in after the release, I think with four eyes and the perftest experiments we should find any potential regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org