You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/06/23 08:53:09 UTC

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured

rohityadavcloud commented on code in PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#discussion_r904754621


##########
systemvm/debian/opt/cloud/bin/setup/init.sh:
##########
@@ -188,6 +188,7 @@ setup_interface_sshd() {
     setup_sshd $ETH1_IP "eth1"
 
   elif [ "$TYPE" == "vpcrouter" ]; then
+    init_interfaces "eth0"

Review Comment:
   why not move this entirely to the appliance/type specific script cc @weizhouapache @Pearl1594 ? This would avoid requiring new systemvmtemplate anytime the init (or early-config?) script.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org