You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/10 11:01:17 UTC
[GitHub] [spark] yaooqinn opened a new pull request, #36497: [SPARK-39138][SQL] Add ANSI general value specification and function - user
yaooqinn opened a new pull request, #36497:
URL: https://github.com/apache/spark/pull/36497
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add ANSI general value specification and function - user
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
According to ANSI SQL,
```
CURRENT_USER and USER are semantically the same
```
USER is also supported by other systems like MySQL, PG, hive, etc.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
new function added
for ansi mode, and if enforceReservedKeywords, USER always reserved
otherwise, it will be resolved as a literal if no attribute matches.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
new tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #36497: [SPARK-39138][SQL] Add ANSI general value specification and function - user
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #36497:
URL: https://github.com/apache/spark/pull/36497#issuecomment-1124491436
cc @HyukjinKwon @cloud-fan thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a diff in pull request #36497: [SPARK-39138][SQL] Add ANSI general value specification and function - user
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #36497:
URL: https://github.com/apache/spark/pull/36497#discussion_r872184124
##########
sql/core/src/test/scala/org/apache/spark/sql/MiscFunctionsSuite.scala:
##########
@@ -47,15 +47,17 @@ class MiscFunctionsSuite extends QueryTest with SharedSparkSession {
test("SPARK-21957: get current_user in normal spark apps") {
val user = spark.sparkContext.sparkUser
withSQLConf(SQLConf.ANSI_ENABLED.key -> "false") {
- val df = sql("select current_user(), current_user")
- checkAnswer(df, Row(user, user))
+ val df = sql("select current_user(), current_user, user, user()")
+ checkAnswer(df, Row(user, user, user, user))
}
withSQLConf(SQLConf.ANSI_ENABLED.key -> "true",
SQLConf.ENFORCE_RESERVED_KEYWORDS.key -> "true") {
- val df = sql("select current_user")
- checkAnswer(df, Row(spark.sparkContext.sparkUser))
- val e = intercept[ParseException](sql("select current_user()"))
- assert(e.getMessage.contains("current_user"))
+ val df = sql("select current_user, user")
Review Comment:
we are not testing errors with this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn closed pull request #36497: [SPARK-39138][SQL] Add ANSI general value specification and function - user
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #36497: [SPARK-39138][SQL] Add ANSI general value specification and function - user
URL: https://github.com/apache/spark/pull/36497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #36497: [SPARK-39138][SQL] Add ANSI general value specification and function - user
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #36497:
URL: https://github.com/apache/spark/pull/36497#issuecomment-1126216693
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #36497: [SPARK-39138][SQL] Add ANSI general value specification and function - user
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #36497:
URL: https://github.com/apache/spark/pull/36497#discussion_r872177862
##########
sql/core/src/test/scala/org/apache/spark/sql/MiscFunctionsSuite.scala:
##########
@@ -47,15 +47,17 @@ class MiscFunctionsSuite extends QueryTest with SharedSparkSession {
test("SPARK-21957: get current_user in normal spark apps") {
val user = spark.sparkContext.sparkUser
withSQLConf(SQLConf.ANSI_ENABLED.key -> "false") {
- val df = sql("select current_user(), current_user")
- checkAnswer(df, Row(user, user))
+ val df = sql("select current_user(), current_user, user, user()")
+ checkAnswer(df, Row(user, user, user, user))
}
withSQLConf(SQLConf.ANSI_ENABLED.key -> "true",
SQLConf.ENFORCE_RESERVED_KEYWORDS.key -> "true") {
- val df = sql("select current_user")
- checkAnswer(df, Row(spark.sparkContext.sparkUser))
- val e = intercept[ParseException](sql("select current_user()"))
- assert(e.getMessage.contains("current_user"))
+ val df = sql("select current_user, user")
Review Comment:
for the error test, we need to test these 2 separately. otherwise we don't know which one caused the error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org