[GitHub] [bookkeeper] nicoloboschi commented on a diff in pull request #3317: Fix maven javadoc generate

[GitBox <gi...@apache.org>]

nicoloboschi commented on code in PR #3317:
URL: https://github.com/apache/bookkeeper/pull/3317#discussion_r890979011


##########
.github/workflows/pr-validation.yml:
##########
@@ -56,6 +56,5 @@ jobs:
       - name: Check license files
         run: dev/check-all-licenses
 
-      # keeping on gradle, `mvn site javadoc:javadoc`, to figure out later
       - name: Generate Javadoc
-        run: ./gradlew generateApiJavadoc
+        run: mvn clean -B -nsu -am -pl :bookkeeper-common,:bookkeeper-server,:bookkeeper-stats-api,:bookkeeper-stats-providers,:codahale-metrics-provider,:prometheus-metrics-provider install javadoc:aggregate -DskipTests -Pdelombok

Review Comment:
   the Maven standard syntax for `-pl` does not require the colon, I'd prefer to remove them



##########
stream/distributedlog/pom.xml:
##########
@@ -47,8 +47,9 @@
         <artifactId>maven-javadoc-plugin</artifactId>
         <version>${maven-javadoc-plugin.version}</version>
         <configuration>
+          <sourcepath>${src.dir}</sourcepath>
+          <notimestamp>true</notimestamp>
           <!-- Avoid for missing javadoc comments to be marked as errors -->

Review Comment:
   no longer useful comment



##########
site3/website/scripts/javadoc-gen.sh:
##########
@@ -34,7 +34,7 @@ function build_javadoc() {
   if [[ "$use_gradle" == "true" ]]; then
     ./gradlew generateApiJavadoc
   else
-    mvn clean install javadoc:aggregate -DskipTests
+    mvn clean -B -nsu -am -pl :bookkeeper-common,:bookkeeper-server,:bookkeeper-stats-api,:bookkeeper-stats-providers,:codahale-metrics-provider,:prometheus-metrics-provider install javadoc:aggregate -DskipTests -Pdelombok

Review Comment:
   the Maven standard syntax for -pl does not require the colon, I'd prefer to remove them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org