[GitHub] [thrift] Agent-Tao opened a new pull request #2389: fix rebuildSelector that may leak channels when rebuilding selector w…

[GitBox <gi...@apache.org>]

Agent-Tao opened a new pull request #2389:
URL: https://github.com/apache/thrift/pull/2389


   fix rebuildSelector that may leak channels when rebuilding selector which may cause lots of close_wait at client side.
   
   <!-- Explain the changes in the pull request below: -->
   1、newSelector create failed, should return immediately  
   2、should register all select keys, not only readykeys. which cause channel leak.
   3、should migrate interestOps
   
   this logic is similar to netty, please refer:  https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/channel/nio/NioEventLoop.java
   
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [ ] Did you squash your changes to a single commit?  (not required, but preferred)
   - [ ] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org