You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Sebastian Mattheis (Jira)" <ji...@apache.org> on 2022/03/22 17:55:00 UTC
[jira] [Comment Edited] (FLINK-25505) Fix NetworkBufferPoolTest, SystemResourcesCounterTest on Apple M1
[ https://issues.apache.org/jira/browse/FLINK-25505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510797#comment-17510797 ]
Sebastian Mattheis edited comment on FLINK-25505 at 3/22/22, 5:54 PM:
----------------------------------------------------------------------
[~rmetzger] I'm upgrading to oshi-core 6.1.5 and I'm about filing a PR. However, I would like to check back with you if my changes fix this issue:
My system is using an Apple M1 Pro and I'm sure I have seen failing both NetworkBufferPoolTest and SystemResourcesCounterTest some time during setup. However, I have *not* seen failing NetworkBufferPoolTest after installing rosetta on my system which I installed with
{code:bash}
softwareupdate --install-rosetta {code}
(I may be wrong and non-failing NetworkBufferPoolTest has nothing to do with rosetta but I can't test it because softwareupdate cannot be reverted.)
Only SystemResourcesCounterTest kept failing which is now fixed for me with the upgrade to oshi-core 6.1.5 where the following succeeds
{code:bash}
mvn -Dtest="org.apache.flink.runtime.**.*Test" -DfailIfNoTests=false test{code}
*My question is:*
Do you think it solves this issue or should we investigate more why NetworkBufferPoolTest failed and under what conditions and if it keeps failing under those conditions also with the changes?
My change is a single (WIP) commit: [https://github.com/smattheis/flink/commit/2ec1f9964970cf32babbc0b1bfaaa7cfdea9ca13]
was (Author: JIRAUSER284806):
[~rmetzger] I'm upgrading to oshi-core 6.1.5 and I'm about filing a PR. However, I would like to check back with you if my changes fix this issue:
My system is using an Apple M1 Pro and I'm sure I have seen failing both NetworkBufferPoolTest and SystemResourcesCounterTest some time during setup. However, I have *not* seen failing NetworkBufferPoolTest after installing rosetta on my system which I installed with
{code:bash}
softwareupdate --install-rosetta {code}
(I may be wrong and non-failing NetworkBufferPoolTest has nothing to do with rosetta but I can't test it because softwareupdate cannot be reverted.)
Only SystemResourcesCounterTest kept failing which is now fixed for me with the upgrade to oshi-core 6.1.5 where the following succeeds
{code:bash}
mvn -Dtest="org.apache.flink.runtime.**.*Test" -DfailIfNoTests=false test{code}
*My question is:*
Do you think it solves this issue or should we investigate more why NetworkBufferPoolTest failed and under what conditions and if it keeps failing under those conditions also with the changes?
My change is a single commit: [https://github.com/smattheis/flink/commit/2ec1f9964970cf32babbc0b1bfaaa7cfdea9ca13]
> Fix NetworkBufferPoolTest, SystemResourcesCounterTest on Apple M1
> ------------------------------------------------------------------
>
> Key: FLINK-25505
> URL: https://issues.apache.org/jira/browse/FLINK-25505
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Metrics, Runtime / Network
> Affects Versions: 1.15.0, 1.16.0
> Reporter: Robert Metzger
> Assignee: Sebastian Mattheis
> Priority: Major
>
> As discussed in https://issues.apache.org/jira/browse/FLINK-23230, some tests in flink-runtime are not passing on M1 / Apple Silicon Macs.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)