[GitHub] [solr] epugh commented on a diff in pull request #1247: SOLR-10464: setCollectionCacheTTL should be deprecated in favor of Solr Client Builder methods

[GitBox <gi...@apache.org>]

epugh commented on code in PR #1247:
URL: https://github.com/apache/solr/pull/1247#discussion_r1060032483


##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudLegacySolrClient.java:
##########
@@ -270,6 +271,17 @@ public Builder withLBHttpSolrClient(LBHttpSolrClient loadBalancedSolrClient) {
       return this;
     }
 
+    /**
+     * Sets the cache ttl for DocCollection Objects cached.
+     *
+     * @param seconds ttl value in seconds
+     */
+    public Builder setCollectionCacheTtl(int seconds) {

Review Comment:
   I'm going to go with `with` for now, as I'm anxious to get this committed.   There is a seperate JIRA out to ask for more global feedback....   and this could always be changed at that point ;-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org