You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/03/19 11:13:11 UTC
[GitHub] [incubator-doris] yangzhg opened a new pull request #3148: improve
performent of hash join in some case
yangzhg opened a new pull request #3148: improve performent of hash join in some case
URL: https://github.com/apache/incubator-doris/pull/3148
improve performent of hash join when build table has to many duplicated row, this wii cause hash table collisions and slow down the probe performent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #3148: improve
performent of hash join in some case
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #3148: improve performent of hash join in some case
URL: https://github.com/apache/incubator-doris/pull/3148
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request
#3148: improve performent of hash join in some case
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #3148: improve performent of hash join in some case
URL: https://github.com/apache/incubator-doris/pull/3148#discussion_r395410965
##########
File path: be/src/exec/hash_join_node_ir.cpp
##########
@@ -137,11 +137,20 @@ int HashJoinNode::process_probe_batch(RowBatch* out_batch, RowBatch* probe_batch
return rows_returned;
}
+// when build table has too many duplicated rows, the collisions will be very serious,
+// so in some case will don't need to store duplicated value in hash table, we can build an unique one
void HashJoinNode::process_build_batch(RowBatch* build_batch) {
// insert build row into our hash table
for (int i = 0; i < build_batch->num_rows(); ++i) {
- _hash_tbl->insert(build_batch->get_row(i));
+ if (_join_op == TJoinOp::LEFT_ANTI_JOIN|| _join_op == TJoinOp::RIGHT_ANTI_JOIN
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on issue #3148: improve performent
of hash join in some case
Posted by GitBox <gi...@apache.org>.
imay commented on issue #3148: improve performent of hash join in some case
URL: https://github.com/apache/incubator-doris/pull/3148#issuecomment-601150670
This is a wonderful job! 💯
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request
#3148: improve performent of hash join in some case
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3148: improve performent of hash join in some case
URL: https://github.com/apache/incubator-doris/pull/3148#discussion_r395001565
##########
File path: be/src/exec/hash_join_node_ir.cpp
##########
@@ -137,11 +137,20 @@ int HashJoinNode::process_probe_batch(RowBatch* out_batch, RowBatch* probe_batch
return rows_returned;
}
+// when build table has too many duplicated rows, the collisions will be very serious,
+// so in some case will don't need to store duplicated value in hash table, we can build an unique one
void HashJoinNode::process_build_batch(RowBatch* build_batch) {
// insert build row into our hash table
for (int i = 0; i < build_batch->num_rows(); ++i) {
- _hash_tbl->insert(build_batch->get_row(i));
+ if (_join_op == TJoinOp::LEFT_ANTI_JOIN|| _join_op == TJoinOp::RIGHT_ANTI_JOIN
Review comment:
I think these compare can be done just once when initializing the HashJoinNode, no need to judge it for every row.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on issue #3148: improve
performent of hash join in some case
Posted by GitBox <gi...@apache.org>.
yangzhg commented on issue #3148: improve performent of hash join in some case
URL: https://github.com/apache/incubator-doris/pull/3148#issuecomment-601148947
> Hi, @yangzhg
> Could you attach some benchmark for this PR?
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on issue #3148: improve performent
of hash join in some case
Posted by GitBox <gi...@apache.org>.
imay commented on issue #3148: improve performent of hash join in some case
URL: https://github.com/apache/incubator-doris/pull/3148#issuecomment-601131188
Hi, @yangzhg
Could you attach some benchmark for this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org