[jira] [Commented] (GERONIMO-6686) OpenAPI operationId is not unique

["Romain Manni-Bucau (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GERONIMO-6686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747739#comment-16747739 ] 

Romain Manni-Bucau commented on GERONIMO-6686:
----------------------------------------------

Hi [~deki], what's the fix you suggest?

I see 3 options here:

1. Fail (throw new InvalidDeploymentOperationId())
2. Ignore the operationId of the user (and corrupt its expectation)
3. Current impl: do nothing and let him fix it if needed (in some env it works fine). We can add an error log in this case but outcome is the same: it deploys.

Personally I tend to prefer 3 but I can see space for 1 too. Maybe we should add a config for that, default being current one with a log.error? wdyt?

> OpenAPI operationId is not unique
> ---------------------------------
>
>                 Key: GERONIMO-6686
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-6686
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>            Reporter: Dennis Kieselhorst
>            Priority: Major
>             Fix For: OpenAPI_1.0.5
>
>
> Spec says:
> _{{operationId}} is an optional unique string used to identify an operation. If provided, these IDs must be unique among all operations described in your API._
> Currently if two resource classes provide a method with the same name the operationId is not unique.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)