You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@wicket.apache.org by Live Nono <li...@gmail.com> on 2009/05/20 10:51:25 UTC
Example of ModalWindow misleading
Hi
The example here :
http://www.wicket-library.com/wicket-examples/ajax/modal-window.1 is
pretty misleading : passing components between components/page is
quite broken as can be seen in the past discussion on the mailing list
(serialization issue can arise and makes both sides using different
references of the same object "logically speaking").
However, as it is in the example, I first used it considering that it
should be ok to do so.
Could it be changed in some way ?
On the bigger picture, I guess it raises again the issue of the
"recommended" way of communicating between the page and the modal
window, which currently doesn't exist (session, database...??).
However, this example is currently completely misleading, so even so
comments to explicit the issue would be welcomed.
thanks again
nono
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Example of ModalWindow misleading
Posted by Live Nono <li...@gmail.com>.
done : https://issues.apache.org/jira/browse/WICKET-2295
nono
2009/5/28, Igor Vaynberg <ig...@gmail.com>:
> yes
>
>
> -igor
>
>
> On Thu, May 28, 2009 at 3:09 AM, Live Nono <li...@gmail.com> wrote:
> > Should I open a jira for this ?
> >
> >
> >
> > 2009/5/21 Matej Knopp <ma...@gmail.com>:
> >> I think modal window example could be fixed by using
> >> getPageReference() to pass page reference between pages instead of
> >> page instance.
> >>
> >> -Matej
> >>
> >> On Wed, May 20, 2009 at 10:29 PM, Martin Makundi
> >> <ma...@koodaripalvelut.com> wrote:
> >>>> http://www.wicket-library.com/wicket-examples/ajax/modal-window.1 is
> >>>> pretty misleading : passing components between components/page is
> >>>> quite broken as can be seen in the past discussion on the mailing list
> >>>> (serialization issue can arise and makes both sides using different
> >>>> references of the same object "logically speaking").
> >>>
> >>> True.
> >>>
> >>> I have found that the only safe way to pass references is via
> >>> getSession().xxx so now all my (not all, but generally relevant ones)
> >>> models are in session instead of being page-scoped. Not heavy models
> >>> but selection models such that indicate what the user is operating on.
> >>>
> >>> However. Instead of changing the documentation, I would rather change
> >>> the implementation such that the serialization would not break.
> >>>
> >>> The same offect, however, occurs if you have some other kind of pop-up
> >>> window.... it would be nice to be able to continue using the
> >>> underlying page in sync with the pop-up.
> >>>
> >>>
> >>>
> >>> **
> >>> Martin
> >>>
> >>>>
> >>>> However, as it is in the example, I first used it considering that it
> >>>> should be ok to do so.
> >>>>
> >>>> Could it be changed in some way ?
> >>>>
> >>>> On the bigger picture, I guess it raises again the issue of the
> >>>> "recommended" way of communicating between the page and the modal
> >>>> window, which currently doesn't exist (session, database...??).
> >>>> However, this example is currently completely misleading, so even so
> >>>> comments to explicit the issue would be welcomed.
> >>>>
> >>>> thanks again
> >>>> nono
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> >>>> For additional commands, e-mail: users-help@wicket.apache.org
> >>>>
> >>>>
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> >>> For additional commands, e-mail: users-help@wicket.apache.org
> >>>
> >>>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> >> For additional commands, e-mail: users-help@wicket.apache.org
> >>
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > For additional commands, e-mail: users-help@wicket.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Example of ModalWindow misleading
Posted by Igor Vaynberg <ig...@gmail.com>.
yes
-igor
On Thu, May 28, 2009 at 3:09 AM, Live Nono <li...@gmail.com> wrote:
> Should I open a jira for this ?
>
>
>
> 2009/5/21 Matej Knopp <ma...@gmail.com>:
>> I think modal window example could be fixed by using
>> getPageReference() to pass page reference between pages instead of
>> page instance.
>>
>> -Matej
>>
>> On Wed, May 20, 2009 at 10:29 PM, Martin Makundi
>> <ma...@koodaripalvelut.com> wrote:
>>>> http://www.wicket-library.com/wicket-examples/ajax/modal-window.1 is
>>>> pretty misleading : passing components between components/page is
>>>> quite broken as can be seen in the past discussion on the mailing list
>>>> (serialization issue can arise and makes both sides using different
>>>> references of the same object "logically speaking").
>>>
>>> True.
>>>
>>> I have found that the only safe way to pass references is via
>>> getSession().xxx so now all my (not all, but generally relevant ones)
>>> models are in session instead of being page-scoped. Not heavy models
>>> but selection models such that indicate what the user is operating on.
>>>
>>> However. Instead of changing the documentation, I would rather change
>>> the implementation such that the serialization would not break.
>>>
>>> The same offect, however, occurs if you have some other kind of pop-up
>>> window.... it would be nice to be able to continue using the
>>> underlying page in sync with the pop-up.
>>>
>>>
>>>
>>> **
>>> Martin
>>>
>>>>
>>>> However, as it is in the example, I first used it considering that it
>>>> should be ok to do so.
>>>>
>>>> Could it be changed in some way ?
>>>>
>>>> On the bigger picture, I guess it raises again the issue of the
>>>> "recommended" way of communicating between the page and the modal
>>>> window, which currently doesn't exist (session, database...??).
>>>> However, this example is currently completely misleading, so even so
>>>> comments to explicit the issue would be welcomed.
>>>>
>>>> thanks again
>>>> nono
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>>>> For additional commands, e-mail: users-help@wicket.apache.org
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>>> For additional commands, e-mail: users-help@wicket.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> For additional commands, e-mail: users-help@wicket.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Example of ModalWindow misleading
Posted by Live Nono <li...@gmail.com>.
Should I open a jira for this ?
2009/5/21 Matej Knopp <ma...@gmail.com>:
> I think modal window example could be fixed by using
> getPageReference() to pass page reference between pages instead of
> page instance.
>
> -Matej
>
> On Wed, May 20, 2009 at 10:29 PM, Martin Makundi
> <ma...@koodaripalvelut.com> wrote:
>>> http://www.wicket-library.com/wicket-examples/ajax/modal-window.1 is
>>> pretty misleading : passing components between components/page is
>>> quite broken as can be seen in the past discussion on the mailing list
>>> (serialization issue can arise and makes both sides using different
>>> references of the same object "logically speaking").
>>
>> True.
>>
>> I have found that the only safe way to pass references is via
>> getSession().xxx so now all my (not all, but generally relevant ones)
>> models are in session instead of being page-scoped. Not heavy models
>> but selection models such that indicate what the user is operating on.
>>
>> However. Instead of changing the documentation, I would rather change
>> the implementation such that the serialization would not break.
>>
>> The same offect, however, occurs if you have some other kind of pop-up
>> window.... it would be nice to be able to continue using the
>> underlying page in sync with the pop-up.
>>
>>
>>
>> **
>> Martin
>>
>>>
>>> However, as it is in the example, I first used it considering that it
>>> should be ok to do so.
>>>
>>> Could it be changed in some way ?
>>>
>>> On the bigger picture, I guess it raises again the issue of the
>>> "recommended" way of communicating between the page and the modal
>>> window, which currently doesn't exist (session, database...??).
>>> However, this example is currently completely misleading, so even so
>>> comments to explicit the issue would be welcomed.
>>>
>>> thanks again
>>> nono
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>>> For additional commands, e-mail: users-help@wicket.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> For additional commands, e-mail: users-help@wicket.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Example of ModalWindow misleading
Posted by Matej Knopp <ma...@gmail.com>.
I think modal window example could be fixed by using
getPageReference() to pass page reference between pages instead of
page instance.
-Matej
On Wed, May 20, 2009 at 10:29 PM, Martin Makundi
<ma...@koodaripalvelut.com> wrote:
>> http://www.wicket-library.com/wicket-examples/ajax/modal-window.1 is
>> pretty misleading : passing components between components/page is
>> quite broken as can be seen in the past discussion on the mailing list
>> (serialization issue can arise and makes both sides using different
>> references of the same object "logically speaking").
>
> True.
>
> I have found that the only safe way to pass references is via
> getSession().xxx so now all my (not all, but generally relevant ones)
> models are in session instead of being page-scoped. Not heavy models
> but selection models such that indicate what the user is operating on.
>
> However. Instead of changing the documentation, I would rather change
> the implementation such that the serialization would not break.
>
> The same offect, however, occurs if you have some other kind of pop-up
> window.... it would be nice to be able to continue using the
> underlying page in sync with the pop-up.
>
>
>
> **
> Martin
>
>>
>> However, as it is in the example, I first used it considering that it
>> should be ok to do so.
>>
>> Could it be changed in some way ?
>>
>> On the bigger picture, I guess it raises again the issue of the
>> "recommended" way of communicating between the page and the modal
>> window, which currently doesn't exist (session, database...??).
>> However, this example is currently completely misleading, so even so
>> comments to explicit the issue would be welcomed.
>>
>> thanks again
>> nono
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> For additional commands, e-mail: users-help@wicket.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Example of ModalWindow misleading
Posted by Martin Makundi <ma...@koodaripalvelut.com>.
> http://www.wicket-library.com/wicket-examples/ajax/modal-window.1 is
> pretty misleading : passing components between components/page is
> quite broken as can be seen in the past discussion on the mailing list
> (serialization issue can arise and makes both sides using different
> references of the same object "logically speaking").
True.
I have found that the only safe way to pass references is via
getSession().xxx so now all my (not all, but generally relevant ones)
models are in session instead of being page-scoped. Not heavy models
but selection models such that indicate what the user is operating on.
However. Instead of changing the documentation, I would rather change
the implementation such that the serialization would not break.
The same offect, however, occurs if you have some other kind of pop-up
window.... it would be nice to be able to continue using the
underlying page in sync with the pop-up.
**
Martin
>
> However, as it is in the example, I first used it considering that it
> should be ok to do so.
>
> Could it be changed in some way ?
>
> On the bigger picture, I guess it raises again the issue of the
> "recommended" way of communicating between the page and the modal
> window, which currently doesn't exist (session, database...??).
> However, this example is currently completely misleading, so even so
> comments to explicit the issue would be welcomed.
>
> thanks again
> nono
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org