You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "HTHou (via GitHub)" <gi...@apache.org> on 2024/11/21 04:43:33 UTC
[PR] Table session [iotdb]
HTHou opened a new pull request, #14157:
URL: https://github.com/apache/iotdb/pull/14157
## Description
### Content1 ...
### Content2 ...
### Content3 ...
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error
conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition,
design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design
(or naming) decision point and compare the alternatives with the designs that you've implemented
(or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere
(e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list),
link to that discussion from this PR description and explain what have changed in your final design
compared to your original proposal or the consensus version in the end of the discussion.
If something hasn't changed since the original discussion, you can omit a detailed discussion of
those aspects of the design here, perhaps apart from brief mentioning for the sake of readability
of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] concurrent read
- [ ] concurrent write
- [ ] concurrent read and write
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods.
- [ ] added or updated version, __license__, or notice information
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
- [ ] added integration tests.
- [ ] been tested in a test IoTDB cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items
apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items
from the checklist above are strictly necessary, but it would be very helpful if you at least
self-review the PR. -->
<hr>
##### Key changed/added classes (or packages if there are too many classes) in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Table session [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14157:
URL: https://github.com/apache/iotdb/pull/14157#issuecomment-2490950336
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) **Quality Gate failed**
Failed conditions
 [5.3% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=14157&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)
 [E Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) (required ≥ A)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Table session [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14157:
URL: https://github.com/apache/iotdb/pull/14157#issuecomment-2491101969
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) **Quality Gate failed**
Failed conditions
 [5.3% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=14157&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)
 [E Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) (required ≥ A)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Table session [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14157:
URL: https://github.com/apache/iotdb/pull/14157#issuecomment-2492843024
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) **Quality Gate failed**
Failed conditions
 [5.3% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=14157&metric=new_duplicated_lines_density&view=list) (required ≤ 5%)
 [E Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) (required ≥ A)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Table session [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14157:
URL: https://github.com/apache/iotdb/pull/14157#issuecomment-2490729848
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) **Quality Gate failed**
Failed conditions
 [5.4% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=14157&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)
 [E Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) (required ≥ A)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Table session [iotdb]
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on code in PR #14157:
URL: https://github.com/apache/iotdb/pull/14157#discussion_r1853212981
##########
iotdb-client/session/src/main/java/org/apache/iotdb/session/pool/TableSessionWrapper.java:
##########
@@ -131,67 +107,19 @@ public void executeNonQueryStatement(String sql)
}
@Override
- public String getTimestampPrecision() throws TException {
- try {
- return session.getTimestampPrecision();
- } catch (TException e) {
- sessionPool.cleanSessionAndMayThrowConnectionException(session);
- closed.set(true);
- session = null;
- throw e;
- }
- }
-
- @Override
- public void insertTablet(Tablet tablet)
- throws StatementExecutionException, IoTDBConnectionException {
- try {
- session.insertRelationalTablet(tablet);
- } catch (IoTDBConnectionException e) {
- sessionPool.cleanSessionAndMayThrowConnectionException(session);
- closed.set(true);
- session = null;
- throw e;
- }
- }
-
- @Override
- public boolean isEnableQueryRedirection() {
- return session.isEnableQueryRedirection();
- }
-
- @Override
- public boolean isEnableRedirection() {
- return session.isEnableRedirection();
- }
-
- @Override
- public TSBackupConfigurationResp getBackupConfiguration()
- throws IoTDBConnectionException, StatementExecutionException {
- try {
- return session.getBackupConfiguration();
- } catch (IoTDBConnectionException e) {
- sessionPool.cleanSessionAndMayThrowConnectionException(session);
- closed.set(true);
- session = null;
- throw e;
- }
- }
-
- @Override
- public TSConnectionInfoResp fetchAllConnections() throws IoTDBConnectionException {
- try {
- return session.fetchAllConnections();
- } catch (IoTDBConnectionException e) {
- sessionPool.cleanSessionAndMayThrowConnectionException(session);
- closed.set(true);
+ public void close() throws IoTDBConnectionException {
+ if (closed.compareAndSet(false, true)) {
+ if (!Objects.equals(session.getDatabase(), sessionPool.database)
+ && sessionPool.database != null) {
+ try {
+ session.executeNonQueryStatement("use " + sessionPool.database);
+ } catch (StatementExecutionException e) {
+ LOGGER.warn(
+ "Failed to change back database by executing: use {}", sessionPool.database, e);
+ }
+ }
+ sessionPool.putBack(session);
Review Comment:
OK, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Table session [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14157:
URL: https://github.com/apache/iotdb/pull/14157#issuecomment-2490219371
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) **Quality Gate failed**
Failed conditions
 [E Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) (required ≥ A)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Table session [iotdb]
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou merged PR #14157:
URL: https://github.com/apache/iotdb/pull/14157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Table session [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14157:
URL: https://github.com/apache/iotdb/pull/14157#issuecomment-2490076877
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) **Quality Gate failed**
Failed conditions
 [E Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) (required ≥ A)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Table session [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14157:
URL: https://github.com/apache/iotdb/pull/14157#issuecomment-2491131742
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) **Quality Gate failed**
Failed conditions
 [5.3% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=14157&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)
 [E Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) (required ≥ A)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Table session [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14157:
URL: https://github.com/apache/iotdb/pull/14157#issuecomment-2490283088
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) **Quality Gate failed**
Failed conditions
 [E Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) (required ≥ A)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Table session [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14157:
URL: https://github.com/apache/iotdb/pull/14157#issuecomment-2490254944
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) **Quality Gate failed**
Failed conditions
 [E Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) (required ≥ A)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Table session [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14157:
URL: https://github.com/apache/iotdb/pull/14157#issuecomment-2492776858
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) **Quality Gate failed**
Failed conditions
 [5.3% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=14157&metric=new_duplicated_lines_density&view=list) (required ≤ 5%)
 [E Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) (required ≥ A)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Table session [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14157:
URL: https://github.com/apache/iotdb/pull/14157#issuecomment-2490829186
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) **Quality Gate failed**
Failed conditions
 [5.3% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=14157&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)
 [E Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) (required ≥ A)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Table session [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #14157:
URL: https://github.com/apache/iotdb/pull/14157#issuecomment-2490127802
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/14157?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `24.69880%` with `125 lines` in your changes missing coverage. Please review.
> Project coverage is 39.62%. Comparing base [(`f8bcf2a`)](https://app.codecov.io/gh/apache/iotdb/commit/f8bcf2adec6993dd7d3442e78484cd87ef0a2d27?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`0fb3d9b`)](https://app.codecov.io/gh/apache/iotdb/commit/0fb3d9bc2a1ec481b014a78c839fd34f1d9f3d9a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 9 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/14157?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/iotdb/session/pool/TableSessionPoolBuilder.java](https://app.codecov.io/gh/apache/iotdb/pull/14157?src=pr&el=tree&filepath=iotdb-client%2Fsession%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fsession%2Fpool%2FTableSessionPoolBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY2xpZW50L3Nlc3Npb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL3Nlc3Npb24vcG9vbC9UYWJsZVNlc3Npb25Qb29sQnVpbGRlci5qYXZh) | 0.00% | [46 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/14157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/iotdb/session/TableSessionBuilder.java](https://app.codecov.io/gh/apache/iotdb/pull/14157?src=pr&el=tree&filepath=iotdb-client%2Fsession%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fsession%2FTableSessionBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY2xpZW50L3Nlc3Npb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL3Nlc3Npb24vVGFibGVTZXNzaW9uQnVpbGRlci5qYXZh) | 0.00% | [45 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/14157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/iotdb/session/pool/TableSessionWrapper.java](https://app.codecov.io/gh/apache/iotdb/pull/14157?src=pr&el=tree&filepath=iotdb-client%2Fsession%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fsession%2Fpool%2FTableSessionWrapper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY2xpZW50L3Nlc3Npb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL3Nlc3Npb24vcG9vbC9UYWJsZVNlc3Npb25XcmFwcGVyLmphdmE=) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/14157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/iotdb/session/TableSession.java](https://app.codecov.io/gh/apache/iotdb/pull/14157?src=pr&el=tree&filepath=iotdb-client%2Fsession%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fsession%2FTableSession.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY2xpZW50L3Nlc3Npb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL3Nlc3Npb24vVGFibGVTZXNzaW9uLmphdmE=) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/14157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/iotdb/session/pool/TableSessionPool.java](https://app.codecov.io/gh/apache/iotdb/pull/14157?src=pr&el=tree&filepath=iotdb-client%2Fsession%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fsession%2Fpool%2FTableSessionPool.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY2xpZW50L3Nlc3Npb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL3Nlc3Npb24vcG9vbC9UYWJsZVNlc3Npb25Qb29sLmphdmE=) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/14157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/iotdb/session/pool/SessionPool.java](https://app.codecov.io/gh/apache/iotdb/pull/14157?src=pr&el=tree&filepath=iotdb-client%2Fsession%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fsession%2Fpool%2FSessionPool.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY2xpZW50L3Nlc3Npb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL3Nlc3Npb24vcG9vbC9TZXNzaW9uUG9vbC5qYXZh) | 72.72% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/14157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #14157 +/- ##
============================================
- Coverage 39.65% 39.62% -0.03%
Complexity 71 71
============================================
Files 4224 4229 +5
Lines 269197 269326 +129
Branches 32623 32641 +18
============================================
- Hits 106738 106714 -24
- Misses 162459 162612 +153
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/14157?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
----
🚨 Try these New Features:
- [Flaky Tests Detection](https://docs.codecov.com/docs/test-result-ingestion-beta) - Detect and resolve failed and flaky tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Table session [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14157:
URL: https://github.com/apache/iotdb/pull/14157#issuecomment-2490358283
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) **Quality Gate failed**
Failed conditions
 [E Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157) (required ≥ A)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14157)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Table session [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 commented on code in PR #14157:
URL: https://github.com/apache/iotdb/pull/14157#discussion_r1853207090
##########
iotdb-client/session/src/main/java/org/apache/iotdb/session/pool/TableSessionWrapper.java:
##########
@@ -131,67 +107,19 @@ public void executeNonQueryStatement(String sql)
}
@Override
- public String getTimestampPrecision() throws TException {
- try {
- return session.getTimestampPrecision();
- } catch (TException e) {
- sessionPool.cleanSessionAndMayThrowConnectionException(session);
- closed.set(true);
- session = null;
- throw e;
- }
- }
-
- @Override
- public void insertTablet(Tablet tablet)
- throws StatementExecutionException, IoTDBConnectionException {
- try {
- session.insertRelationalTablet(tablet);
- } catch (IoTDBConnectionException e) {
- sessionPool.cleanSessionAndMayThrowConnectionException(session);
- closed.set(true);
- session = null;
- throw e;
- }
- }
-
- @Override
- public boolean isEnableQueryRedirection() {
- return session.isEnableQueryRedirection();
- }
-
- @Override
- public boolean isEnableRedirection() {
- return session.isEnableRedirection();
- }
-
- @Override
- public TSBackupConfigurationResp getBackupConfiguration()
- throws IoTDBConnectionException, StatementExecutionException {
- try {
- return session.getBackupConfiguration();
- } catch (IoTDBConnectionException e) {
- sessionPool.cleanSessionAndMayThrowConnectionException(session);
- closed.set(true);
- session = null;
- throw e;
- }
- }
-
- @Override
- public TSConnectionInfoResp fetchAllConnections() throws IoTDBConnectionException {
- try {
- return session.fetchAllConnections();
- } catch (IoTDBConnectionException e) {
- sessionPool.cleanSessionAndMayThrowConnectionException(session);
- closed.set(true);
+ public void close() throws IoTDBConnectionException {
+ if (closed.compareAndSet(false, true)) {
+ if (!Objects.equals(session.getDatabase(), sessionPool.database)
+ && sessionPool.database != null) {
+ try {
+ session.executeNonQueryStatement("use " + sessionPool.database);
+ } catch (StatementExecutionException e) {
+ LOGGER.warn(
+ "Failed to change back database by executing: use {}", sessionPool.database, e);
+ }
+ }
+ sessionPool.putBack(session);
Review Comment:
If the execution fails, is it still necessary to put the session back?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org