You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/03/10 00:51:47 UTC
Review Request 66004: Updated task reconciliation path to avoid
copying in v1.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66004/
-----------------------------------------------------------
Review request for mesos, Meng Zhu and Jiang Yan Xu.
Bugs: MESOS-8628
https://issues.apache.org/jira/browse/MESOS-8628
Repository: mesos
Description
-------
This enforces the pattern of v0 messages converting to a v1
message and passing through the v1 logic.
From a performance perspective, the v1 path no longer copies into
a `vector<TaskStatus>` which should offer improved performance.
In the v0 path, we now move into a `Reconcile` message rather than
moving into a `vector<TaskStatus>`. Therefore, this improves v1
performance while keeping v0 performance roughly the same in terms
of copying.
Diffs
-----
src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f
src/master/master.hpp 8bf2c763dafdb7df55c46a56f2ff66f2a951d947
src/master/master.cpp f0f6e5b91b4eae99dec52725f5efc203695c41e8
Diff: https://reviews.apache.org/r/66004/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 66004: Updated task reconciliation path to avoid
copying in v1.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66004/#review198987
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66004]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 9, 2018, 4:51 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66004/
> -----------------------------------------------------------
>
> (Updated March 9, 2018, 4:51 p.m.)
>
>
> Review request for mesos, Meng Zhu and Jiang Yan Xu.
>
>
> Bugs: MESOS-8628
> https://issues.apache.org/jira/browse/MESOS-8628
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This enforces the pattern of v0 messages converting to a v1
> message and passing through the v1 logic.
>
> From a performance perspective, the v1 path no longer copies into
> a `vector<TaskStatus>` which should offer improved performance.
> In the v0 path, we now move into a `Reconcile` message rather than
> moving into a `vector<TaskStatus>`. Therefore, this improves v1
> performance while keeping v0 performance roughly the same in terms
> of copying.
>
>
> Diffs
> -----
>
> src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f
> src/master/master.hpp 8bf2c763dafdb7df55c46a56f2ff66f2a951d947
> src/master/master.cpp f0f6e5b91b4eae99dec52725f5efc203695c41e8
>
>
> Diff: https://reviews.apache.org/r/66004/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 66004: Updated task reconciliation path to avoid
copying in v1.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66004/#review199385
-----------------------------------------------------------
Ship it!
Ship It!
- Meng Zhu
On March 9, 2018, 4:51 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66004/
> -----------------------------------------------------------
>
> (Updated March 9, 2018, 4:51 p.m.)
>
>
> Review request for mesos, Meng Zhu and Jiang Yan Xu.
>
>
> Bugs: MESOS-8628
> https://issues.apache.org/jira/browse/MESOS-8628
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This enforces the pattern of v0 messages converting to a v1
> message and passing through the v1 logic.
>
> From a performance perspective, the v1 path no longer copies into
> a `vector<TaskStatus>` which should offer improved performance.
> In the v0 path, we now move into a `Reconcile` message rather than
> moving into a `vector<TaskStatus>`. Therefore, this improves v1
> performance while keeping v0 performance roughly the same in terms
> of copying.
>
>
> Diffs
> -----
>
> src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f
> src/master/master.hpp 8bf2c763dafdb7df55c46a56f2ff66f2a951d947
> src/master/master.cpp f0f6e5b91b4eae99dec52725f5efc203695c41e8
>
>
> Diff: https://reviews.apache.org/r/66004/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 66004: Updated task reconciliation path to avoid
copying in v1.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66004/#review198980
-----------------------------------------------------------
PASS: Mesos patch 66004 was successfully built and tested.
Reviews applied: `['66004']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66004
- Mesos Reviewbot Windows
On March 10, 2018, 12:51 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66004/
> -----------------------------------------------------------
>
> (Updated March 10, 2018, 12:51 a.m.)
>
>
> Review request for mesos, Meng Zhu and Jiang Yan Xu.
>
>
> Bugs: MESOS-8628
> https://issues.apache.org/jira/browse/MESOS-8628
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This enforces the pattern of v0 messages converting to a v1
> message and passing through the v1 logic.
>
> From a performance perspective, the v1 path no longer copies into
> a `vector<TaskStatus>` which should offer improved performance.
> In the v0 path, we now move into a `Reconcile` message rather than
> moving into a `vector<TaskStatus>`. Therefore, this improves v1
> performance while keeping v0 performance roughly the same in terms
> of copying.
>
>
> Diffs
> -----
>
> src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f
> src/master/master.hpp 8bf2c763dafdb7df55c46a56f2ff66f2a951d947
> src/master/master.cpp f0f6e5b91b4eae99dec52725f5efc203695c41e8
>
>
> Diff: https://reviews.apache.org/r/66004/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>