[GitHub] [hbase] apurtell commented on a change in pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes

[GitBox <gi...@apache.org>]

apurtell commented on a change in pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#discussion_r629524850



##########
File path: hbase-rest/pom.xml
##########
@@ -160,7 +151,6 @@
     <dependency>
       <groupId>org.apache.hbase</groupId>
       <artifactId>hbase-protocol-shaded</artifactId>
-      <type>jar</type>

Review comment:
       This was just redundant, right?

##########
File path: hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java
##########
@@ -18,22 +17,19 @@
  */
 package org.apache.hadoop.hbase.rest.model;
 
+import com.fasterxml.jackson.annotation.JsonInclude;

Review comment:
       Should be org.apache.hbase.thirdparty.com.fasterxml.jackson...

##########
File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/RowResourceBase.java
##########
@@ -18,22 +18,16 @@
 package org.apache.hadoop.hbase.rest;
 
 import static org.junit.Assert.assertEquals;
-
 import com.fasterxml.jackson.databind.ObjectMapper;

Review comment:
       We aren't shading jackson-databind? Shouldn't we, if we are shading other jackson packages? jackson.databind has been a source of several CVEs so is definitely something we want to control and keep an eye on. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org