You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by ijuma <gi...@git.apache.org> on 2017/05/31 12:05:36 UTC

[GitHub] kafka pull request #3177: MINOR: Set baseSequence correctly if log append ti...

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/3177

    MINOR: Set baseSequence correctly if log append time and no broker recompression

    This makes it consistent with the case where there is recompression. Thanks to
    @edenhill who found the issue while testing librdkafka.
    
    The reason our tests don’t catch this is that we rely on the maxTimestamp
    to compute the record level timestamps if log append time is used.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka set-base-sequence-for-log-append-time

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3177.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3177
    
----
commit 12777a5e0b208bf50bab399f789db56cb3e3dcb3
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-05-31T12:05:10Z

    MINOR: Set baseSequence correctly if log append time and no broker recompression
    
    This makes it consistent with the case where there is recompression. Thanks to
    @edenhill who found the issue while testing librdkafka.
    
    The reason our tests don’t catch this is that we rely on the maxTimestamp
    to compute the record level timestamps if log append time is used.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3177: KAFKA-5353: baseTimestamp should always have a cre...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/3177


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---