You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by Daniel Quirant Rico <da...@gmail.com> on 2018/11/26 22:59:18 UTC
Guacamole extensión MongoDB
Hello,
I have been absent for a while and I am going to resume this project.
I would like to know if any progress has been made in this regard and
I need to document beforehand.
The Jira were GUACAMOLE-605 and GUACAMOLE-617.
I hope to be active soon and continue with this great project.
Thanks and regards.
Re: Guacamole extensión MongoDB
Posted by Daniel Quirant Rico <da...@gmail.com>.
Hello,
After a lot of work, I can finally share with you my contribution to this
project.
You already have available for your review the extension that supports
MongoDB through Morphia.
In addition to a new library in which a large part of the shared code is
available for the authentication module. This part has been restructured
through genericity to be able to reuse it in future implementations if
necessary.
Regards!
El sáb., 12 ene. 2019 a las 18:47, Daniel Quirant Rico (<
daniel.quirant.rico@gmail.com>) escribió:
> Hello,
>
> I have advanced a lot in the development of the common authentication
> extension for jdbc and mongo. At this moment I have a stable enough version
> to share it with you and together find all possible faults that remain to
> be resolved.
> I am aware that there are several errors in the application, but I have a
> deployment booted with MySQL and MongoDB. The two deployments are
> accessible and you can navigate well through the different options, I ask
> for your help to find the errors that may arise when making the different
> possible cases in the application since I do not know the whole functional
> part.
> If you agree I prepare the pull request with my development, this includes
> two new libraries, the implementation of the guacamole database with
> morphia using mongodb and the shared library with all the common code
> between morphia and jdbc for authentication. In addition to the adaptation
> of the existing libraries of jdbc to use the new common dependency.
>
> The name of the classes that I have used may not be suitable, since to
> guide me I chose to name all the classes and interfaces, which had to be
> reimplemented in the specific parts of jdbc and morphia, as an abstract in
> the final part of the name . This will be refactored at the end of the
> development with a more coherent nomenclature.
>
> I hope that the development is at the level you are looking for.
>
> I feel if the language used is not adequate, I do not speak the language
> correctly.
>
> A greeting.
>
> El mar., 8 ene. 2019 a las 17:32, Daniel Quirant Rico (<
> daniel.quirant.rico@gmail.com>) escribió:
>
>> Hello,
>>
>> Thanks for your interest.
>> I have finished the integration and I am solving small errors. During the next week I will try to upload the code, depending on the time I have free to finish reviewing the code, and you can help prove it.
>>
>> PS: I've noticed that in a previous email I mentioned that I was working on version 0.9.4, I meant 0.9.14.
>>
>> Greetings.
>>
>>
>> El dom., 6 ene. 2019 15:26, fou fe <fo...@live.fr> escribió:
>>
>>> Hi
>>> I m interesting to test your extension.
>>> If you need help i m here.
>>>
>>> Fouad
>>>
>>> Télécharger Outlook pour Android <https://aka.ms/ghei36>
>>>
>>> ------------------------------
>>> *From:* Daniel Quirant Rico <da...@gmail.com>
>>> *Sent:* Thursday, January 3, 2019 2:16:17 AM
>>> *To:* dev@guacamole.apache.org
>>> *Subject:* Re: Guacamole extensión MongoDB
>>>
>>> Hello,
>>>
>>> I still work hard on the common base extension, a week ago I finished the
>>> development but there were many changes since I initially fork.
>>> I have updated my fork and am adapting the whole new part of the user
>>> groups to be able to run all the databases. By mistake when updating my
>>> fork I created a pull request, I feel the confusion.
>>> The adaptation completed for version 0.9.4 looks very good, I will
>>> continue
>>> working hard until I complete version 1.0.0.
>>> If you wish, I can upload version 0.9.4 so you can take a look.
>>>
>>> Greetings and happy new year.
>>>
>>> El lun., 17 dic. 2018 a las 21:31, Daniel Quirant Rico (<
>>> daniel.quirant.rico@gmail.com>) escribió:
>>>
>>> > I'm going to review the code a bit more to clean it, for now I have the
>>> > morphia part running, I'll check that everything works in the sql part
>>> and
>>> > I'll do a pull request so you can check it.
>>> >
>>> > El vie., 14 dic. 2018 a las 12:55, Nick Couchman (<vn...@apache.org>)
>>> > escribió:
>>> >
>>> >> >
>>> >> > I think I have explained it more or less well, it is possible that
>>> my
>>> >> > expression in the language is not the most appropriate since I do
>>> not
>>> >> speak
>>> >> > English well.
>>> >> >
>>> >> > I hope you respond with ideas and proposals, as well as your
>>> opinion on
>>> >> > what I am trying to solve.
>>> >> > If you need to see the code, I can share it without problem, even
>>> if it
>>> >> is
>>> >> > not completely finished.
>>> >> >
>>> >>
>>> >> I think you did a great job of explaining it, but I do better seeing
>>> >> actual
>>> >> code, so if you wouldn't mind sharing examples of what you have, that
>>> >> would
>>> >> probably be best, at least for me.
>>> >>
>>> >> -Nick
>>> >>
>>> >
>>>
>>
Re: Guacamole extensión MongoDB
Posted by Daniel Quirant Rico <da...@gmail.com>.
Hello,
I have advanced a lot in the development of the common authentication
extension for jdbc and mongo. At this moment I have a stable enough version
to share it with you and together find all possible faults that remain to
be resolved.
I am aware that there are several errors in the application, but I have a
deployment booted with MySQL and MongoDB. The two deployments are
accessible and you can navigate well through the different options, I ask
for your help to find the errors that may arise when making the different
possible cases in the application since I do not know the whole functional
part.
If you agree I prepare the pull request with my development, this includes
two new libraries, the implementation of the guacamole database with
morphia using mongodb and the shared library with all the common code
between morphia and jdbc for authentication. In addition to the adaptation
of the existing libraries of jdbc to use the new common dependency.
The name of the classes that I have used may not be suitable, since to
guide me I chose to name all the classes and interfaces, which had to be
reimplemented in the specific parts of jdbc and morphia, as an abstract in
the final part of the name . This will be refactored at the end of the
development with a more coherent nomenclature.
I hope that the development is at the level you are looking for.
I feel if the language used is not adequate, I do not speak the language
correctly.
A greeting.
El mar., 8 ene. 2019 a las 17:32, Daniel Quirant Rico (<
daniel.quirant.rico@gmail.com>) escribió:
> Hello,
>
> Thanks for your interest.
> I have finished the integration and I am solving small errors. During the next week I will try to upload the code, depending on the time I have free to finish reviewing the code, and you can help prove it.
>
> PS: I've noticed that in a previous email I mentioned that I was working on version 0.9.4, I meant 0.9.14.
>
> Greetings.
>
>
> El dom., 6 ene. 2019 15:26, fou fe <fo...@live.fr> escribió:
>
>> Hi
>> I m interesting to test your extension.
>> If you need help i m here.
>>
>> Fouad
>>
>> Télécharger Outlook pour Android <https://aka.ms/ghei36>
>>
>> ------------------------------
>> *From:* Daniel Quirant Rico <da...@gmail.com>
>> *Sent:* Thursday, January 3, 2019 2:16:17 AM
>> *To:* dev@guacamole.apache.org
>> *Subject:* Re: Guacamole extensión MongoDB
>>
>> Hello,
>>
>> I still work hard on the common base extension, a week ago I finished the
>> development but there were many changes since I initially fork.
>> I have updated my fork and am adapting the whole new part of the user
>> groups to be able to run all the databases. By mistake when updating my
>> fork I created a pull request, I feel the confusion.
>> The adaptation completed for version 0.9.4 looks very good, I will
>> continue
>> working hard until I complete version 1.0.0.
>> If you wish, I can upload version 0.9.4 so you can take a look.
>>
>> Greetings and happy new year.
>>
>> El lun., 17 dic. 2018 a las 21:31, Daniel Quirant Rico (<
>> daniel.quirant.rico@gmail.com>) escribió:
>>
>> > I'm going to review the code a bit more to clean it, for now I have the
>> > morphia part running, I'll check that everything works in the sql part
>> and
>> > I'll do a pull request so you can check it.
>> >
>> > El vie., 14 dic. 2018 a las 12:55, Nick Couchman (<vn...@apache.org>)
>> > escribió:
>> >
>> >> >
>> >> > I think I have explained it more or less well, it is possible that my
>> >> > expression in the language is not the most appropriate since I do not
>> >> speak
>> >> > English well.
>> >> >
>> >> > I hope you respond with ideas and proposals, as well as your opinion
>> on
>> >> > what I am trying to solve.
>> >> > If you need to see the code, I can share it without problem, even if
>> it
>> >> is
>> >> > not completely finished.
>> >> >
>> >>
>> >> I think you did a great job of explaining it, but I do better seeing
>> >> actual
>> >> code, so if you wouldn't mind sharing examples of what you have, that
>> >> would
>> >> probably be best, at least for me.
>> >>
>> >> -Nick
>> >>
>> >
>>
>
Re: Guacamole extensión MongoDB
Posted by Daniel Quirant Rico <da...@gmail.com>.
Hello,
Thanks for your interest.
I have finished the integration and I am solving small errors. During
the next week I will try to upload the code, depending on the time I
have free to finish reviewing the code, and you can help prove it.
PS: I've noticed that in a previous email I mentioned that I was
working on version 0.9.4, I meant 0.9.14.
Greetings.
El dom., 6 ene. 2019 15:26, fou fe <fo...@live.fr> escribió:
> Hi
> I m interesting to test your extension.
> If you need help i m here.
>
> Fouad
>
> Télécharger Outlook pour Android <https://aka.ms/ghei36>
>
> ------------------------------
> *From:* Daniel Quirant Rico <da...@gmail.com>
> *Sent:* Thursday, January 3, 2019 2:16:17 AM
> *To:* dev@guacamole.apache.org
> *Subject:* Re: Guacamole extensión MongoDB
>
> Hello,
>
> I still work hard on the common base extension, a week ago I finished the
> development but there were many changes since I initially fork.
> I have updated my fork and am adapting the whole new part of the user
> groups to be able to run all the databases. By mistake when updating my
> fork I created a pull request, I feel the confusion.
> The adaptation completed for version 0.9.4 looks very good, I will continue
> working hard until I complete version 1.0.0.
> If you wish, I can upload version 0.9.4 so you can take a look.
>
> Greetings and happy new year.
>
> El lun., 17 dic. 2018 a las 21:31, Daniel Quirant Rico (<
> daniel.quirant.rico@gmail.com>) escribió:
>
> > I'm going to review the code a bit more to clean it, for now I have the
> > morphia part running, I'll check that everything works in the sql part
> and
> > I'll do a pull request so you can check it.
> >
> > El vie., 14 dic. 2018 a las 12:55, Nick Couchman (<vn...@apache.org>)
> > escribió:
> >
> >> >
> >> > I think I have explained it more or less well, it is possible that my
> >> > expression in the language is not the most appropriate since I do not
> >> speak
> >> > English well.
> >> >
> >> > I hope you respond with ideas and proposals, as well as your opinion
> on
> >> > what I am trying to solve.
> >> > If you need to see the code, I can share it without problem, even if
> it
> >> is
> >> > not completely finished.
> >> >
> >>
> >> I think you did a great job of explaining it, but I do better seeing
> >> actual
> >> code, so if you wouldn't mind sharing examples of what you have, that
> >> would
> >> probably be best, at least for me.
> >>
> >> -Nick
> >>
> >
>
Re: Guacamole extensión MongoDB
Posted by Daniel Quirant Rico <da...@gmail.com>.
Hello,
I still work hard on the common base extension, a week ago I finished the
development but there were many changes since I initially fork.
I have updated my fork and am adapting the whole new part of the user
groups to be able to run all the databases. By mistake when updating my
fork I created a pull request, I feel the confusion.
The adaptation completed for version 0.9.4 looks very good, I will continue
working hard until I complete version 1.0.0.
If you wish, I can upload version 0.9.4 so you can take a look.
Greetings and happy new year.
El lun., 17 dic. 2018 a las 21:31, Daniel Quirant Rico (<
daniel.quirant.rico@gmail.com>) escribió:
> I'm going to review the code a bit more to clean it, for now I have the
> morphia part running, I'll check that everything works in the sql part and
> I'll do a pull request so you can check it.
>
> El vie., 14 dic. 2018 a las 12:55, Nick Couchman (<vn...@apache.org>)
> escribió:
>
>> >
>> > I think I have explained it more or less well, it is possible that my
>> > expression in the language is not the most appropriate since I do not
>> speak
>> > English well.
>> >
>> > I hope you respond with ideas and proposals, as well as your opinion on
>> > what I am trying to solve.
>> > If you need to see the code, I can share it without problem, even if it
>> is
>> > not completely finished.
>> >
>>
>> I think you did a great job of explaining it, but I do better seeing
>> actual
>> code, so if you wouldn't mind sharing examples of what you have, that
>> would
>> probably be best, at least for me.
>>
>> -Nick
>>
>
Re: Guacamole extensión MongoDB
Posted by Daniel Quirant Rico <da...@gmail.com>.
I'm going to review the code a bit more to clean it, for now I have the
morphia part running, I'll check that everything works in the sql part and
I'll do a pull request so you can check it.
El vie., 14 dic. 2018 a las 12:55, Nick Couchman (<vn...@apache.org>)
escribió:
> >
> > I think I have explained it more or less well, it is possible that my
> > expression in the language is not the most appropriate since I do not
> speak
> > English well.
> >
> > I hope you respond with ideas and proposals, as well as your opinion on
> > what I am trying to solve.
> > If you need to see the code, I can share it without problem, even if it
> is
> > not completely finished.
> >
>
> I think you did a great job of explaining it, but I do better seeing actual
> code, so if you wouldn't mind sharing examples of what you have, that would
> probably be best, at least for me.
>
> -Nick
>
Re: Guacamole extensión MongoDB
Posted by Nick Couchman <vn...@apache.org>.
>
> I think I have explained it more or less well, it is possible that my
> expression in the language is not the most appropriate since I do not speak
> English well.
>
> I hope you respond with ideas and proposals, as well as your opinion on
> what I am trying to solve.
> If you need to see the code, I can share it without problem, even if it is
> not completely finished.
>
I think you did a great job of explaining it, but I do better seeing actual
code, so if you wouldn't mind sharing examples of what you have, that would
probably be best, at least for me.
-Nick
Re: Guacamole extensión MongoDB
Posted by Daniel Quirant Rico <da...@gmail.com>.
Hello,
I am finishing the implementation of the extension, but I have reached a
point where I must make an important decision about the structure of the
data model in order to finish.
For the implementation with morphia-mongodb it is necessary that the
relationship between the different models be made by classes, storing an
object within another object to which the relation refers, instead of only
storing the id of the other entity.
This means, in case I have not explained myself well, for example:
Person:
id,
first name,
etc
Cat:
id,
first name,
Owner (Person)
Having these two tables, in the Cat class an object of the type Person
would be stored, instead of a simple field that refers to the id of the
Person.
With this clear, I am in the situation where original implementation is
based on relationships through a simple field that refers to the id of the
other table, but the implementation for morphia is based on the
relationship with objects.
To finish the common extension, I need to modify this in such a way that
both parties can continue working without altering a large part of the
project.
My proposals are:
1 - Use for all cases the relation by means of objects, since the relation
by means of id is not compatible with both cases.
This is the simplest option and it can give less problems.
It would no longer be necessary to recover the relationships, by means of
the id since you always have the data of the related object.
The only drawback would be to include more information than necessary in
some cases.
2 - Create several interfaces that inherit from the same base, in which
each inheritance on said interface adds the necessary methods.
This option is more complex, since it requires a deeper analysis to
abstract each model with a customized interface for each case.
It must also overwrite the basic methods to get the id inside the object,
so that the rest of the project keeps calling its methods.
The project should have many interfaces to implement the necessary methods
that do not exist in the main interfaces.
In addition it is very likely that castings must be added to the interfaces
controlling at all times what type of extension is being worked on.
I think I have explained it more or less well, it is possible that my
expression in the language is not the most appropriate since I do not speak
English well.
I hope you respond with ideas and proposals, as well as your opinion on
what I am trying to solve.
If you need to see the code, I can share it without problem, even if it is
not completely finished.
A greeting.
El mié., 28 nov. 2018 a las 1:56, Nick Couchman (<vn...@apache.org>)
escribió:
> On Mon, Nov 26, 2018 at 5:59 PM Daniel Quirant Rico <
> daniel.quirant.rico@gmail.com> wrote:
>
> > Hello,
> >
> > I have been absent for a while and I am going to resume this project.
> > I would like to know if any progress has been made in this regard and
> > I need to document beforehand.
> > The Jira were GUACAMOLE-605 and GUACAMOLE-617.
> > I hope to be active soon and continue with this great project.
> >
> >
> I haven't personally worked on these, and have not seen anything from
> anyone else indicating progress on these, so I think it's all up to you!
>
> :-D
>
> -Nick
>
Re: Guacamole extensión MongoDB
Posted by Nick Couchman <vn...@apache.org>.
On Mon, Nov 26, 2018 at 5:59 PM Daniel Quirant Rico <
daniel.quirant.rico@gmail.com> wrote:
> Hello,
>
> I have been absent for a while and I am going to resume this project.
> I would like to know if any progress has been made in this regard and
> I need to document beforehand.
> The Jira were GUACAMOLE-605 and GUACAMOLE-617.
> I hope to be active soon and continue with this great project.
>
>
I haven't personally worked on these, and have not seen anything from
anyone else indicating progress on these, so I think it's all up to you!
:-D
-Nick