You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/18 09:11:19 UTC

[GitHub] [incubator-superset] villebro commented on pull request #9777: Check for empty dataframes before processing

villebro commented on pull request #9777:
URL: https://github.com/apache/incubator-superset/pull/9777#issuecomment-660454027


   @bryanck did you ensure that all changed viz' worked correctly with the new logic? I would be inclined to merge this, as the "No Results" notification is much more intuitive than the myriad exceptions that tend to surface otherwise on legacy viz plugins.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org