You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/13 02:52:50 UTC
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1513: Ftr: support custom registry group name on nacos for 1.5
codecov-commenter edited a comment on pull request #1513:
URL: https://github.com/apache/dubbo-go/pull/1513#issuecomment-941856457
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1513?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1513](https://codecov.io/gh/apache/dubbo-go/pull/1513?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c4797dd) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/a4b4f50aa23b06e59c7945054b5bf9c56718a76d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4b4f50) will **decrease** coverage by `0.10%`.
> The diff coverage is `51.61%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1513?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 1.5 #1513 +/- ##
==========================================
- Coverage 55.72% 55.62% -0.11%
==========================================
Files 279 279
Lines 16024 16065 +41
==========================================
+ Hits 8930 8936 +6
- Misses 6153 6189 +36
+ Partials 941 940 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1513?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/logger/logger.go](https://codecov.io/gh/apache/dubbo-go/pull/1513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2xvZ2dlci9sb2dnZXIuZ28=) | `92.75% <ø> (ø)` | |
| [common/logger/logging.go](https://codecov.io/gh/apache/dubbo-go/pull/1513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2xvZ2dlci9sb2dnaW5nLmdv) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
| [protocol/invocation/rpcinvocation.go](https://codecov.io/gh/apache/dubbo-go/pull/1513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvaW52b2NhdGlvbi9ycGNpbnZvY2F0aW9uLmdv) | `16.66% <0.00%> (-0.61%)` | :arrow_down: |
| [registry/service\_instance.go](https://codecov.io/gh/apache/dubbo-go/pull/1513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvc2VydmljZV9pbnN0YW5jZS5nbw==) | `0.00% <ø> (ø)` | |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `43.84% <40.00%> (-0.51%)` | :arrow_down: |
| [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `70.68% <66.66%> (-0.08%)` | :arrow_down: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/1513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3VybC5nbw==) | `62.02% <100.00%> (+0.45%)` | :arrow_up: |
| [registry/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvbGlzdGVuZXIuZ28=) | `82.35% <100.00%> (+0.61%)` | :arrow_up: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `52.52% <0.00%> (-12.13%)` | :arrow_down: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `54.71% <0.00%> (-9.44%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/dubbo-go/pull/1513/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1513?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1513?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1dbb573...c4797dd](https://codecov.io/gh/apache/dubbo-go/pull/1513?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org