You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/13 03:31:46 UTC

[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #2719: [Improve][e2e] add driver-jar to lib

TyrantLucifer commented on code in PR #2719:
URL: https://github.com/apache/incubator-seatunnel/pull/2719#discussion_r969116315


##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-jdbc-flink-e2e/src/test/java/org/apache/seatunnel/e2e/flink/v2/jdbc/JdbcSourceToConsoleIT.java:
##########
@@ -99,4 +101,10 @@ public void closePostgreSqlContainer() {
             psl.stop();
         }
     }
+
+    @Override
+    protected void executeExtraCommands(GenericContainer<?> container) throws IOException, InterruptedException {

Review Comment:
   > 
   
   In my opinion, not only will the container download additional jar packages, but it may also execute other commands, such as creating files, etc....
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org