You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by yl...@apache.org on 2020/12/15 12:06:54 UTC
svn commit: r1884456 - /httpd/httpd/trunk/CHANGES
Author: ylavic
Date: Tue Dec 15 12:06:54 2020
New Revision: 1884456
URL: http://svn.apache.org/viewvc?rev=1884456&view=rev
Log:
Follow up to r1884068: CHANGES entry needs to go to 2.5.x too.
[skip ci]
Modified:
httpd/httpd/trunk/CHANGES
Modified: httpd/httpd/trunk/CHANGES
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/CHANGES?rev=1884456&r1=1884455&r2=1884456&view=diff
==============================================================================
--- httpd/httpd/trunk/CHANGES [utf-8] (original)
+++ httpd/httpd/trunk/CHANGES [utf-8] Tue Dec 15 12:06:54 2020
@@ -1,6 +1,10 @@
-*- coding: utf-8 -*-
Changes with Apache 2.5.1
+ *) mod_proxy_fcgi: Honor "SetEnv proxy-sendcl" to forward a chunked
+ Transfer-Encoding from the client, spooling the request body when needed
+ to provide a Content-Length to the backend. PR 57087. [Yann Ylavic]
+
*) core: add ReadBufferSize, FlushMaxThreshold and FlushMaxPipelined
directives. [Yann Ylavic]
Re: svn commit: r1884456 - /httpd/httpd/trunk/CHANGES
Posted by Yann Ylavic <yl...@gmail.com>.
On Tue, Dec 15, 2020 at 4:38 PM Yann Ylavic <yl...@gmail.com> wrote:
>
> Doing that now messes up CHANGES completely though (some binary
> garbage gets inserted) :/
Hm no actually, I just retried by reverting everything first and there
is no garbage at all (just the pr57087 is duplicated..).
Forget that, it's rather me producing garbage :)
Re: svn commit: r1884456 - /httpd/httpd/trunk/CHANGES
Posted by Yann Ylavic <yl...@gmail.com>.
On Tue, Dec 15, 2020 at 9:36 PM Ruediger Pluem <rp...@apache.org> wrote:
>
> On 12/15/20 4:38 PM, Yann Ylavic wrote:
> >
> > When should we do that? I suppose anytime on trunk and when merging on
> > 2.4.x (or at worst when releasing)?
> Correct. Any time on trunk or if you don't want to have it on the trunk CHANGES remove
> the file just after committing it. It is still there for the backport.
> See also README.CHANGES.
> For 2.4.x you can execute it after backporting, but since http://svn.apache.org/viewvc?view=revision&revision=1881738
> the tag.sh script will do it before tagging a release.
That's great tooling, thanks Rüdiger!
Now MMN :)
Regards;
Yann.
Re: svn commit: r1884456 - /httpd/httpd/trunk/CHANGES
Posted by Ruediger Pluem <rp...@apache.org>.
On 12/15/20 4:38 PM, Yann Ylavic wrote:
> On Tue, Dec 15, 2020 at 3:48 PM Ruediger Pluem <rp...@apache.org> wrote:
>>
>> Did you use
>>
>> make update-changes
>>
>> to do the above modification to CHANGES?
>>
>> I guess not as this would have removed the now unneeded trunk/changes-entries/pr57087.txt
>
> Argh no indeed, I knew I missed something :)
>
> Doing that now messes up CHANGES completely though (some binary
> garbage gets inserted) :/
> If I remove my manual addition from this commit (r1884456) it works
> nicely, for all the remaining changes-entries/*.
> When should we do that? I suppose anytime on trunk and when merging on
> 2.4.x (or at worst when releasing)?
Correct. Any time on trunk or if you don't want to have it on the trunk CHANGES remove
the file just after committing it. It is still there for the backport.
See also README.CHANGES.
For 2.4.x you can execute it after backporting, but since http://svn.apache.org/viewvc?view=revision&revision=1881738
the tag.sh script will do it before tagging a release.
Regards
Rüdiger
Re: svn commit: r1884456 - /httpd/httpd/trunk/CHANGES
Posted by Yann Ylavic <yl...@gmail.com>.
On Tue, Dec 15, 2020 at 3:48 PM Ruediger Pluem <rp...@apache.org> wrote:
>
> Did you use
>
> make update-changes
>
> to do the above modification to CHANGES?
>
> I guess not as this would have removed the now unneeded trunk/changes-entries/pr57087.txt
Argh no indeed, I knew I missed something :)
Doing that now messes up CHANGES completely though (some binary
garbage gets inserted) :/
If I remove my manual addition from this commit (r1884456) it works
nicely, for all the remaining changes-entries/*.
When should we do that? I suppose anytime on trunk and when merging on
2.4.x (or at worst when releasing)?
Regards;
Yann.
Re: svn commit: r1884456 - /httpd/httpd/trunk/CHANGES
Posted by Ruediger Pluem <rp...@apache.org>.
On 12/15/20 1:06 PM, ylavic@apache.org wrote:
> Author: ylavic
> Date: Tue Dec 15 12:06:54 2020
> New Revision: 1884456
>
> URL: http://svn.apache.org/viewvc?rev=1884456&view=rev
> Log:
> Follow up to r1884068: CHANGES entry needs to go to 2.5.x too.
>
> [skip ci]
>
> Modified:
> httpd/httpd/trunk/CHANGES
>
> Modified: httpd/httpd/trunk/CHANGES
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/CHANGES?rev=1884456&r1=1884455&r2=1884456&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/CHANGES [utf-8] (original)
> +++ httpd/httpd/trunk/CHANGES [utf-8] Tue Dec 15 12:06:54 2020
> @@ -1,6 +1,10 @@
> -*- coding: utf-8 -*-
> Changes with Apache 2.5.1
>
> + *) mod_proxy_fcgi: Honor "SetEnv proxy-sendcl" to forward a chunked
> + Transfer-Encoding from the client, spooling the request body when needed
> + to provide a Content-Length to the backend. PR 57087. [Yann Ylavic]
> +
> *) core: add ReadBufferSize, FlushMaxThreshold and FlushMaxPipelined
> directives. [Yann Ylavic]
>
Did you use
make update-changes
to do the above modification to CHANGES?
I guess not as this would have removed the now unneeded trunk/changes-entries/pr57087.txt
Regards
Rüdiger