You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tzulitai <gi...@git.apache.org> on 2018/05/17 17:05:38 UTC

[GitHub] flink issue #6040: [FLINK-9349][Kafka Connector] KafkaConnector Exception wh...

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/6040
  
    Thanks for the PR @snuyanzin!
    I had some comments, please let me know what you think.
    
    Also, some general contribution tips:
    1. I would suggest the title of the PR to be something along the lines of "[FLINK-9349] [kafka] Fix ConcurrentModificationException when add discovered partitions". That directly makes it clear what exactly is being fixed.
    2. The message of the first commit of the PR should also be appropriately set to be similar to the title (most of the time if it is a 1-commit PR, the title of the PR and the commit message can be identical).


---