[GitHub] [shardingsphere] sandynz opened a new pull request, #21928: Add sharding columns in SQL condition for migration incremental task

[GitBox <gi...@apache.org>]

sandynz opened a new pull request, #21928:
URL: https://github.com/apache/shardingsphere/pull/21928

   Currently, shardingColumnsMap is always empty for migration job, UPDATE/DELETE SQL in incremental task doesn't include sharding columns in condition, so the logic SQL will be routed broadcastly, it might hurt performance.
   
   shardingColumnsMap was set before, it should be set up again.
   
   Changes proposed in this pull request:
     - Add ShardingColumnsExtractor and implementation
     - Use shardingColumnsMap for migration job
     - Update related migration IT: t_order use user_id as sharding column; Some improvement of IT
     - Fix bugs found in real test: 1) sharding strategy type should be case-insensitive, 2) error message in ShardingSphereSQLException is missed
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yx9o merged pull request #21928: Add sharding columns in SQL condition for migration incremental task

[GitBox <gi...@apache.org>]

yx9o merged PR #21928:
URL: https://github.com/apache/shardingsphere/pull/21928


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org