[GitHub] [spark] zsxwing commented on a change in pull request #30528: [SPARK-33587][Core]Kill the executor on nested fatal errors

[GitBox <gi...@apache.org>]

zsxwing commented on a change in pull request #30528:
URL: https://github.com/apache/spark/pull/30528#discussion_r532091528



##########
File path: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala
##########
@@ -402,6 +403,73 @@ class ExecutorSuite extends SparkFunSuite
     assert(taskMetrics.getMetricValue("JVMHeapMemory") > 0)
   }
 
+  test("SPARK-33587: isFatalError") {
+    def errorInThreadPool(e: => Throwable): Throwable = {

Review comment:
       Trying to make this test cover the cases I mentioned in the description.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org