You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/09/02 05:35:14 UTC
Re: Review Request 68068: Added tests for task metadata GC using the
default executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68068/#review208238
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Aug. 23, 2018, 2:33 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68068/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 2:33 a.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds two tests that launch a long-lived and short-lived task
> on the same executor. The tests expect the short-lived task's
> metadata and sandbox to be garbage collected.
>
> One test restarts the agent before GC to ensure recovery will
> schedule completed tasks for GC too.
>
> One existing test is modified due to the extra GC event from
> task metadata.
>
>
> Diffs
> -----
>
> src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421
> src/tests/slave_recovery_tests.cpp 9710518db30ce3826284f3b7e323bdd9aa207831
>
>
> Diff: https://reviews.apache.org/r/68068/diff/4/
>
>
> Testing
> -------
>
> make check (OSX)
>
> (Other platforms pending...)
>
>
> Thanks,
>
> Joseph Wu
>
>