You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "jbertram (via GitHub)" <gi...@apache.org> on 2023/05/31 18:13:30 UTC

[GitHub] [activemq-artemis] jbertram opened a new pull request, #4497: ARTEMIS-4292 support more Micrometer system metrics

jbertram opened a new pull request, #4497:
URL: https://github.com/apache/activemq-artemis/pull/4497

   This commit exposes Micrometer's system metrics for:
    - file descriptors
    - processor
    - uptime


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] clebertsuconic merged pull request #4497: ARTEMIS-4292 support more Micrometer system metrics

Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic merged PR #4497:
URL: https://github.com/apache/activemq-artemis/pull/4497


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] brusdev commented on a diff in pull request #4497: ARTEMIS-4292 support more Micrometer system metrics

Posted by "brusdev (via GitHub)" <gi...@apache.org>.
brusdev commented on code in PR #4497:
URL: https://github.com/apache/activemq-artemis/pull/4497#discussion_r1212843572


##########
artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/FileConfigurationTest.java:
##########
@@ -575,6 +575,9 @@ public void testDefaults() {
       assertTrue(metricsConfiguration.isJvmGc());
       assertTrue(metricsConfiguration.isJvmThread());
       assertTrue(metricsConfiguration.isNettyPool());
+      assertTrue(metricsConfiguration.isFileDescriptors());

Review Comment:
   Should `testMetrics` be updated?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org