You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@ant.apache.org by Stefan Bodewig <bo...@apache.org> on 2011/08/04 17:05:20 UTC
Re: junit task xml output omits failure message if it contains the word " more"?
On 2011-07-28, Bob Billings wrote:
> However, the Ant junit XML formatter strips off the first line with
> the failure message in any test failure where the failure message
> contains the word " more", resulting in just the "at ...." line
> remaining, which is what shows up in CruiseControl's email.
Oh my, it must have taken quite some time to identify the word "more"
has been the culprit. Sorry, really. Please open a bugzilla report for
this so knowledge is preserved and others don't have to hunt down the
same problem as well.
> I was wondering whether this qualifies as something worth fixing,
> since:
> - anybody using CruiseControl with Ant-run JUnit tests is fairly likely to
> run into it (it should be fairly common to fail a test when there are "more
> of X than there should be")
> - it's unlikely that anybody running into this problem will suspect the word
> "more" as the culprit
> - and even if they do know, it's hard to implement a policy of "Okay
> everybody, remember not to use the word 'more' in your failure messages."
I agree with you, in particular with the last point.
To make things worse the manual page of the junit task does not list
"more" as one of the strings that are filtered out.
As a workaround you can set filtertrace to false, of course, but this is
no real fix.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@ant.apache.org
For additional commands, e-mail: user-help@ant.apache.org
Re: junit task xml output omits failure message if it contains the word " more"?
Posted by Bob Billings <di...@gmail.com>.
Yeah, that would suit my purposes. Seems like the first line is the only one likely to contain a space before the word " more" anyway, aside from the line we want to strip.
Bob
On Aug 5, 2011, at 8:40 AM, Stefan Bodewig <bo...@apache.org> wrote:
> On 2011-08-04, Robert E. Billings III wrote:
>
>> OK, I'll fill out a bugzilla report. Thanks for verifying! :)
>
> Would it be enough if we simply started filtering after the first line
> of the stack trace? That fix would be easiest to implement.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@ant.apache.org
> For additional commands, e-mail: user-help@ant.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@ant.apache.org
For additional commands, e-mail: user-help@ant.apache.org
Re: junit task xml output omits failure message if it contains the word " more"?
Posted by Stefan Bodewig <bo...@apache.org>.
On 2011-08-04, Robert E. Billings III wrote:
> OK, I'll fill out a bugzilla report. Thanks for verifying! :)
Would it be enough if we simply started filtering after the first line
of the stack trace? That fix would be easiest to implement.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@ant.apache.org
For additional commands, e-mail: user-help@ant.apache.org
Re: junit task xml output omits failure message if it contains the
word " more"?
Posted by "Robert E. Billings III" <bo...@tekassoc.com>.
OK, I'll fill out a bugzilla report. Thanks for verifying! :)
Bob
On Thu, Aug 4, 2011 at 11:05 AM, Stefan Bodewig <bo...@apache.org> wrote:
> On 2011-07-28, Bob Billings wrote:
>
> > However, the Ant junit XML formatter strips off the first line with
> > the failure message in any test failure where the failure message
> > contains the word " more", resulting in just the "at ...." line
> > remaining, which is what shows up in CruiseControl's email.
>
> Oh my, it must have taken quite some time to identify the word "more"
> has been the culprit. Sorry, really. Please open a bugzilla report for
> this so knowledge is preserved and others don't have to hunt down the
> same problem as well.
>
> > I was wondering whether this qualifies as something worth fixing,
> > since:
>
> > - anybody using CruiseControl with Ant-run JUnit tests is fairly likely
> to
> > run into it (it should be fairly common to fail a test when there are
> "more
> > of X than there should be")
> > - it's unlikely that anybody running into this problem will suspect the
> word
> > "more" as the culprit
> > - and even if they do know, it's hard to implement a policy of "Okay
> > everybody, remember not to use the word 'more' in your failure messages."
>
> I agree with you, in particular with the last point.
>
> To make things worse the manual page of the junit task does not list
> "more" as one of the strings that are filtered out.
>
> As a workaround you can set filtertrace to false, of course, but this is
> no real fix.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@ant.apache.org
> For additional commands, e-mail: user-help@ant.apache.org
>
>