[GitHub] [spark] HyukjinKwon commented on a change in pull request #32384: [SPARK-35257][TESTS] Speed up `HadoopVersionInfoSuite` with `SPARK_VERSIONS_SUITE_IVY_PATH`

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #32384:
URL: https://github.com/apache/spark/pull/32384#discussion_r622664398



##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HadoopVersionInfoSuite.scala
##########
@@ -35,39 +34,33 @@ class HadoopVersionInfoSuite extends SparkFunSuite {
   override protected val enableAutoThreadAudit = false
 
   test("SPARK-32256: Hadoop VersionInfo should be preloaded") {
-    val ivyPath =
-      Utils.createTempDir(namePrefix = s"${classOf[HadoopVersionInfoSuite].getSimpleName}-ivy")

Review comment:
       @LuciferYang, I think it's okay to use the temp dir to be extra safe. It speeds up but the downside is potential side-effect from the reused ivy. 1 min overhead should be okay




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org