[GitHub] [trafficserver] maskit opened a new pull request, #10294: Fix connect failure count

["maskit (via GitHub)" <gi...@apache.org>]

maskit opened a new pull request, #10294:
URL: https://github.com/apache/trafficserver/pull/10294

   If you look at the code on 9.2.x, the code is basically:
   ```
   if (time_down) {
   
   } else {  // Clear the failure
     info->app.http_data.fail_count   = 0;
     info->app.http_data.last_failure = time_down;
   }
   ```
   but on master it's like
   ```
   if (time_down != TS_TIME_ZERO) {
     if (++count < max_retry) {
   
     } else {  // Clear the failure
       info->app.http_data.fail_count   = 0;
       info->app.http_data.last_failure = time_down;
     }
   }
   ```
   So the counter never reaches max_retry.
   
   The code on 9.2.x:
   https://github.com/apache/trafficserver/blob/6ffbdab2906e15a1a6bab7288e6afbcac48808aa/proxy/http/HttpSM.cc#L5615-L5643


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] maskit merged pull request #10294: Fix connect failure count

["maskit (via GitHub)" <gi...@apache.org>]

maskit merged PR #10294:
URL: https://github.com/apache/trafficserver/pull/10294


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org