You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Julian Foad <ju...@wandisco.com> on 2010/12/01 13:49:22 UTC
Re: Can I add "NOT NULL" to PRISTINE table columns?
> Julian Foad <ju...@wandisco.com> writes:
>
> > I imagine it should be possible to add 'NOT NULL' to these columns
> > without performing a format bump or writing any upgrade code. Am I
> > right?
Hyrum Wright wrote:
> If we're already enforcing it in the C code, I see no problem with
> doing so in the sql schema. Additionally, I don't really see how you
> could add the 'NOT NULL' clause in a format bump without doing table
> duplication, which doesn't seem worth the trouble for something like
> this.
Right.
Philip Martin wrote:
> Existing working copies would not be upgraded, although I suppose the
> client would work. Perhaps make it a format 99 step?
The software won't see any difference except it will provide a sanity
check when we're developing and modifying Subversion code and testing
against new WCs. I don't think there is any need to upgrade existing
development WCs in this respect.
I'll mention it in a comment in the format 99 step, but don't think we
need to write any SQL for it.
Thanks.
- Julian
Re: Can I add "NOT NULL" to PRISTINE table columns?
Posted by Julian Foad <ju...@wandisco.com>.
I (Julian Foad) wrote:
> > Julian Foad <ju...@wandisco.com> writes:
> >
> > > I imagine it should be possible to add 'NOT NULL' to these columns
> > > without performing a format bump or writing any upgrade code. Am I
> > > right?
>
> Hyrum Wright wrote:
> > If we're already enforcing it in the C code, I see no problem with
> > doing so in the sql schema. Additionally, I don't really see how you
> > could add the 'NOT NULL' clause in a format bump without doing table
> > duplication, which doesn't seem worth the trouble for something like
> > this.
>
> Right.
>
> Philip Martin wrote:
> > Existing working copies would not be upgraded, although I suppose the
> > client would work. Perhaps make it a format 99 step?
>
> The software won't see any difference except it will provide a sanity
> check when we're developing and modifying Subversion code and testing
> against new WCs. I don't think there is any need to upgrade existing
> development WCs in this respect.
>
> I'll mention it in a comment in the format 99 step, but don't think we
> need to write any SQL for it.
Committed r1041321.
- Julian